71227 - Installer trashes the memory manager

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P3)

Description

[Simon Fraser [no longer active]]

On quitting, the installer calls DisposePtr on a bunch of things that are really 
handles. This is likely to cause sporadic crashes on quit of the installer.

I'm not sure how this slipped past Spotlight.

Comment 1

[Steve Dagley]

The 6.0/6.01 branch has the offending DisposePtr code #ifdef'ed out.  I suggest 

you move the change to the trunk.  There's no reason for you to deallocate all 

the memory allocation you did (since it's all in the app's heap) as quitting the 

app results in the heap being disposed.

Comment 2

[Samir Gehani]

That soudns good.  (The memory manager doesn't do any special defragmentation
magic or some such I should be aware of and hence make explicit calls to free
allocated memory, right?  That is, it will do any defrag-type magic on its own
when the heap is reclaimed upon app shutdown, right?)

Comment 3

[Steve Dagley]

IIRC all your allocations were done with NewPtr or NewHandle which just allocates 
inside the app heap so no fragmentation worries there.  Only if you were 
allocating in the system heap would you need to worry about freeing the memory 
when you quit.

Comment 4

[Samir Gehani]

Thanks for the confirmation Steve.  

Comment 5

[Samir Gehani]

Fix checked in.

Comment 6

[Grace Bush]

Simon or Steve, would you  verify?  I am not seeing any crashes on file/quit but 
need help with Mac verifies.

Thanks

Comment 7

[Grace Bush]

verified