Closed
Bug 71227
Opened 24 years ago
Closed 24 years ago
Installer trashes the memory manager
Categories
(SeaMonkey :: Installer, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.8.1
People
(Reporter: sfraser_bugs, Assigned: samir_bugzilla)
Details
(Whiteboard: Fix in hand. Waiting for tree to open.)
On quitting, the installer calls DisposePtr on a bunch of things that are really
handles. This is likely to cause sporadic crashes on quit of the installer.
I'm not sure how this slipped past Spotlight.
Assignee | ||
Updated•24 years ago
|
Comment 1•24 years ago
|
||
The 6.0/6.01 branch has the offending DisposePtr code #ifdef'ed out. I suggest
you move the change to the trunk. There's no reason for you to deallocate all
the memory allocation you did (since it's all in the app's heap) as quitting the
app results in the heap being disposed.
Assignee | ||
Comment 2•24 years ago
|
||
That soudns good. (The memory manager doesn't do any special defragmentation
magic or some such I should be aware of and hence make explicit calls to free
allocated memory, right? That is, it will do any defrag-type magic on its own
when the heap is reclaimed upon app shutdown, right?)
Comment 3•24 years ago
|
||
IIRC all your allocations were done with NewPtr or NewHandle which just allocates
inside the app heap so no fragmentation worries there. Only if you were
allocating in the system heap would you need to worry about freeing the memory
when you quit.
Assignee | ||
Comment 4•24 years ago
|
||
Thanks for the confirmation Steve.
Assignee | ||
Updated•24 years ago
|
Target Milestone: mozilla0.9 → mozilla0.8.1
Updated•24 years ago
|
QA Contact: gemal → gbush
Assignee | ||
Updated•24 years ago
|
Whiteboard: Fix in hand. Waiting for tree to open.
Updated•24 years ago
|
Assignee | ||
Comment 5•24 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 6•24 years ago
|
||
Simon or Steve, would you verify? I am not seeing any crashes on file/quit but
need help with Mac verifies.
Thanks
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•