The default bug view has changed. See this FAQ.

(tabs on top) throbber very close to edge

RESOLVED FIXED in Thunderbird 12.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: andreasn, Assigned: andreasn)

Tracking

Trunk
Thunderbird 12.0
x86_64
Windows 7

Thunderbird Tracking Flags

(thunderbird11 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Followup to bug #644169 (comment 155).
Siddharth noted that the throbber in the tab is very close to the edge of the tab.
(Assignee)

Updated

5 years ago
Depends on: 644169
(Assignee)

Comment 1

5 years ago
The text also moves a couple of pixels to the left when the tab is loading, and the throbber is very big itself.
Firefox have two throbbers of nicer size. What one should we take? Both?
Assignee: nobody → nisses.mail
Status: NEW → ASSIGNED
Created attachment 584079 [details] [diff] [review]
Throbber patch

This patch only positions the throbber like the icon. So no more text move.

It's up to you if you want change the trobber.
Attachment #584079 - Flags: review?(nisses.mail)
tracking-thunderbird11: --- → ?
(Assignee)

Comment 3

5 years ago
Created attachment 586120 [details] [diff] [review]
updated throbber patch

This adds the green styled throbber from Firefox to Richards patch. This throbber is more in style with the Win7 cursor loader graphics.
Attachment #584079 - Attachment is obsolete: true
Attachment #584079 - Flags: review?(nisses.mail)
(Assignee)

Comment 4

5 years ago
Created attachment 586137 [details] [diff] [review]
throbber patch v3

This also changes the throbber in the all tabs dropdown.
Attachment #586120 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #586137 - Flags: review?(mconley)
Comment on attachment 586137 [details] [diff] [review]
throbber patch v3

That's gorgeous!  Great work, Andreas!  I'm really quite happy with that. :)

-Mike
Attachment #586137 - Flags: ui-review+
Attachment #586137 - Flags: review?(mconley)
Attachment #586137 - Flags: review+
Comment on attachment 586137 [details] [diff] [review]
throbber patch v3

We'll want this for TB 11 as well.
Attachment #586137 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/7fd685d744ac
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #586137 - Flags: approval-comm-aurora? → approval-comm-aurora+
Checked in: http://hg.mozilla.org/releases/comm-aurora/rev/d03ac4350cd7
status-thunderbird11: --- → fixed
tracking-thunderbird11: ? → ---
You need to log in before you can comment on or make changes to this bug.