712312 - Troubleshooting Information broken due to missing aboutSupport.showWin.label string

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Upon opening Troubleshooting Information, we see the following error:

XML Parsing Error: undefined entity
Location: file:///c:/Users/mconley/mozilla/obj-tb-tot/mozilla/dist/bin/chrome/messenger/content/messenger/about-support/aboutSupport.xhtml
Line Number 144, Column 19:                  &aboutSupport.showWin.label;
------------------^

This looks like fallout from bug 413521, and is causing Mozmill test failures in content-tabs/test-about-support.js.

This bug seems to affect both Windows and Linux.  OSX is not affected.

Comment 1

[Rain [:rain1] (inactive)]

Right, that shouldn't have crept in, heh.

Comment 2

[:aceman]

Sorry about that, my fault. It is an unintended incomplete change that sneaked in patch for bug 413521.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Revert change to aboutSupport.xhtml

This patch reverts the change to aboutSupport.xhtml from bug 413521.

Tested locally on Windows.  This fixes Troubleshooting Information, and the test-about-support.js Mozmill test now passes.

Comment 4

[:aceman]

Yes, revert that change to aboutSupport.xhtml, please.

Could you please help me how to use hg mq to make one patch containing changes in /mail (comm-central) simultaneously with changes to /mozilla (mozilla-central) ? It seems it is handling those tree separately and creating a patch in one of them will not see changes to files in the other one.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-central as http://hg.mozilla.org/comm-central/rev/7e6c0779450e

Comment 6

[Mike Conley (:mconley) (:⚙️)]

aceman:

I'm not sure you can do that, because I believe Mercurial is intentionally "hands off" when it comes to nested repositories.

Your best bet, in my opinion, is to just create separate patches for both repositories.

-Mike

Comment 7

[:aceman]

OK, and then attach both patches into the same bug. Thanks, I can do that.