Last Comment Bug 712312 - Troubleshooting Information broken due to missing aboutSupport.showWin.label string
: Troubleshooting Information broken due to missing aboutSupport.showWin.label ...
: intermittent-failure, regression
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: Trunk
: x86_64 Windows 7
-- normal (vote)
: Thunderbird 11.0
Assigned To: Mike Conley (:mconley)
Depends on:
Blocks: 413521
  Show dependency treegraph
Reported: 2011-12-20 07:56 PST by Mike Conley (:mconley)
Modified: 2012-11-25 19:31 PST (History)
2 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Revert change to aboutSupport.xhtml (1007 bytes, patch)
2011-12-20 08:16 PST, Mike Conley (:mconley)
sid.bugzilla: review+
Details | Diff | Splinter Review

Description User image Mike Conley (:mconley) 2011-12-20 07:56:41 PST
Upon opening Troubleshooting Information, we see the following error:

XML Parsing Error: undefined entity
Location: file:///c:/Users/mconley/mozilla/obj-tb-tot/mozilla/dist/bin/chrome/messenger/content/messenger/about-support/aboutSupport.xhtml
Line Number 144, Column 19:                  &aboutSupport.showWin.label;

This looks like fallout from bug 413521, and is causing Mozmill test failures in content-tabs/test-about-support.js.

This bug seems to affect both Windows and Linux.  OSX is not affected.
Comment 1 User image Siddharth Agarwal [:sid0] (inactive) 2011-12-20 08:01:28 PST
Right, that shouldn't have crept in, heh.
Comment 2 User image :aceman 2011-12-20 08:16:03 PST
Sorry about that, my fault. It is an unintended incomplete change that sneaked in patch for bug 413521.
Comment 3 User image Mike Conley (:mconley) 2011-12-20 08:16:49 PST
Created attachment 583173 [details] [diff] [review]
Revert change to aboutSupport.xhtml

This patch reverts the change to aboutSupport.xhtml from bug 413521.

Tested locally on Windows.  This fixes Troubleshooting Information, and the test-about-support.js Mozmill test now passes.
Comment 4 User image :aceman 2011-12-20 08:25:31 PST
Yes, revert that change to aboutSupport.xhtml, please.

Could you please help me how to use hg mq to make one patch containing changes in /mail (comm-central) simultaneously with changes to /mozilla (mozilla-central) ? It seems it is handling those tree separately and creating a patch in one of them will not see changes to files in the other one.
Comment 5 User image Mike Conley (:mconley) 2011-12-20 08:29:34 PST
Committed to comm-central as
Comment 6 User image Mike Conley (:mconley) 2011-12-20 08:30:55 PST

I'm not sure you can do that, because I believe Mercurial is intentionally "hands off" when it comes to nested repositories.

Your best bet, in my opinion, is to just create separate patches for both repositories.

Comment 7 User image :aceman 2011-12-20 08:35:56 PST
OK, and then attach both patches into the same bug. Thanks, I can do that.

Note You need to log in before you can comment on or make changes to this bug.