712437 - zip_extractall should be moved to utils.py

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

http://hg.mozilla.org/build/talos/file/fd70c47121be/talos/ffsetup.py#l62

zip_extractall (for legacy compatability) arbitrarily lives in
ffsetup.py.  It should probably live in utils.py.  Or, better, it
could be put in a yet-to-be-created mozfile:
https://wiki.mozilla.org/Auto-tools/Projects/MozBase#shared_with_mozharness

Comment 1

[William Lachance (:wlach)]

Note that this method is really only needed so long as we need compatibility with python < 2.6. Python 2.6's zipfile has a built-in extractall() method which does what we want.

Comment 2

[Jeff Hammel]

Sure, but that may not be anytime soon.  If we do start supporting 2.6+ only on talos, this can just go away

Comment 3

[Vinay Kiran]

Attachment: Diff file after moving zip_extractall from ffsetup.py to utils.py

Moved function zip_extractall from ffsetup.py to utils.py

Added a "from utils import zip_extractall" in ffsetup

Comment 4

[cmtalbert]

(In reply to ckvk from comment #3)
> Created attachment 583869 [details] [diff] [review]
> Diff file after moving zip_extractall from ffsetup.py to utils.py
> 
> Moved function zip_extractall from ffsetup.py to utils.py
> 
> Added a "from utils import zip_extractall" in ffsetup

Thanks for the patch!

Comment 5

[Jeff Hammel]

Comment on attachment 583869 [details] [diff] [review]
Diff file after moving zip_extractall from ffsetup.py to utils.py

looks good! Did you test this?  Guessing it should still be run through staging, etc.

Comment 6

[Vinay Kiran]

(In reply to Jeff Hammel [:jhammel] from comment #5)

> looks good! Did you test this?  Guessing it should still be run through
> staging, etc.

Yeah, jhammel. I configured and ran Talos for the ts test. It passed the tests.

Comment 7

[cmtalbert]

Jeff can we get this staged and landed this week?

Comment 8

[Jeff Hammel]

(In reply to Clint Talbert ( :ctalbert ) from comment #7)
> Jeff can we get this staged and landed this week?

Yep, that is doable.  I will try the changes tomorrow (have been having trouble getting access to the staging box from home).

Comment 9

[Jeff Hammel]

staged and pushed: https://bugzilla.mozilla.org/show_bug.cgi?id=712437

Comment 10

[Jeff Hammel]

(In reply to Jeff Hammel [:jhammel] from comment #9)
> staged and pushed: https://bugzilla.mozilla.org/show_bug.cgi?id=712437

Sorry, the URL is supposed to be http://hg.mozilla.org/build/talos/rev/1863e1f6cb62