712439 - class level ffprocess = None can be removed from FFSetup

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

http://hg.mozilla.org/build/talos/file/fd70c47121be/talos/ffsetup.py#l80

It is unused, unusable, and is overridden in the __init__ method:

http://hg.mozilla.org/build/talos/file/fd70c47121be/talos/ffsetup.py#l87

This can just go away.

Comment 1

[Vinay Kiran]

Attachment: Deleted class level ffprocess variable

Deleted the class level variable ffprocess, since it is over-ridden by __init__

Ran talos ts test with new code. The tests came out OK.

Comment 2

[Jeff Hammel]

Comment on attachment 584765 [details] [diff] [review]
Deleted class level ffprocess variable

Looks good!

Comment 3

[Jeff Hammel]

talos.zip created: http://people.mozilla.com/~jhammel/bug712439/talos.zip

Comment 4

[Jeff Hammel]

pushed to Try: https://tbpl.mozilla.org/?tree=Try&rev=c62426514223

Comment 5

[Mozilla RelEng Bot]

Try run for c62426514223 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c62426514223
Results (out of 79 total builds):
    success: 77
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-c62426514223

Comment 6

[Jeff Hammel]

(In reply to Mozilla RelEng Bot from comment #5)
> Try run for c62426514223 is complete.
> Detailed breakdown of the results available here:
>     https://tbpl.mozilla.org/?tree=Try&rev=c62426514223
> Results (out of 79 total builds):
>     success: 77
>     failure: 2
> Builds (or logs if builds failed) available at:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jhammel@mozilla.
> com-c62426514223

These are known and unrelated failures; pushed: http://hg.mozilla.org/build/talos/rev/db8d9e2cce0a

Comment 7

[Jeff Hammel]

Beh, this came is as a blue and wasn't reported by the RelEng Bot: https://tbpl.mozilla.org/php/getParsedLog.php?id=8280936&tree=Try

Not sure if this is related but.....requesting a rebuild.  If it recurs, will revert

Comment 8

[Jeff Hammel]

subsequent dh runs proved successful. :)