712452 - JavaScript strict warning: nsSearchService.js, line 2702: reference to undefined property json._dataType

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect)

Description

[Richard Newman [:rnewman]]

Nightly. Created fresh profile. Closed all tabs. Relaunched.

...
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /Users/rnewman/moz/hg/services-central/content/base/src/nsFrameLoader.cpp, line 419
JavaScript strict warning: file:///Users/rnewman/moz/hg/services-central/obj-ff-dbg/dist/NightlyDebug.app/Contents/MacOS/components/nsSearchService.js, line 2702: reference to undefined property json._dataType
WARNING: Subdocument container has no frame: file /Users/rnewman/moz/hg/services-central/layout/base/nsDocumentViewer.cpp, line 2413
WARNING: Subdocument container has no frame: file /Users/r
...

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The references to json._dataType in _loadEnginesFromCache need to handle it being null and default to SEARCH_DATA_XML, given that _serializeToJSON filters out those values.

On a related note, SRCH_ENG__serializeToJSON() seems to never be called with aFilter==false...

Comment 2

[Martin Mokrejs]

Just hit this with seamonkey-2.33.1

++DOMWINDOW == 15 (0x7fe4a3d36400) [pid = 6567] [serial = 15] [outer = 0x7fe4a3d36000]
JavaScript strict warning: jar:file:///usr/lib64/seamonkey/omni.ja!/components/nsSearchService.js, line 3633: ReferenceError: reference to undefined property json._dataType
JavaScript strict warning: jar:file:///usr/lib64/seamonkey/omni.ja!/components/nsSearchService.js, line 1165: ReferenceError: reference to undefined property param.purpose
++DOCSHELL 0x7fe4a3287300 == 7 [pid = 6567] [id = 7]
++DOMWINDOW == 16 (0x7fe4a089d800) [pid = 6567] [serial = 16] [outer = (nil)]
++DOMWINDOW == 17 (0x7fe4a089dc00) [pid = 6567] [serial = 17] [outer = 0x7fe4a089d800]

Comment 3

[Mark Banner (:standard8)]

There's no _dataType in the tree now and the code has been rewritten -> WFM.