test-content-proxy.testMozMatchedSelector fails against most recent nightly build

RESOLVED FIXED

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: myk, Assigned: ochameau)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
test-content-proxy.testMozMatchedSelector fails against the most recent nightly build:

(addon-sdk)mykbook:api-utils myk$ cfx test -f content-proxy
Using binary at '/Applications/Nightly.app/Contents/MacOS/firefox-bin'.
Using profile at '/var/folders/bN/bN4Z5w6UEdC60cFgLX32NU+++TI/-Tmp-/tmpbAb_Lt.mozrunner'.
Running tests on Firefox 11.0a1/Gecko 11.0a1 ({ec8030f7-c20a-464f-9b0e-13a3a9e97384}) under darwin/x86.
.........................................error: TEST FAILED: test-content-proxy.testMozMatchedSelector (failure)
error: fail: mozMatchesSelector works while being called from a function reference to document.documentElement.mozMatchesSelector.call
info: Traceback (most recent call last):
  File "resource://55af4ff4-704f-4d15-84f5-f9a40a92fb9e-at-jetpack/api-utils/lib/timer.js", line 66, in notifyOnTimeout
    this._callback.apply(null, this._params);
  File "resource://55af4ff4-704f-4d15-84f5-f9a40a92fb9e-at-jetpack/api-utils/lib/utils/function.js", line 63, in invoke
    function invoke(callee, params, self) callee.apply(self, params);
  File "resource://55af4ff4-704f-4d15-84f5-f9a40a92fb9e-at-jetpack/api-utils/lib/events.js", line 153, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://55af4ff4-704f-4d15-84f5-f9a40a92fb9e-at-jetpack/api-utils/lib/events.js", line 183, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://55af4ff4-704f-4d15-84f5-f9a40a92fb9e-at-jetpack/api-utils/tests/test-content-proxy.js", line 77, in null
    test.assert(data.assertion, data.msg);
  File "resource://55af4ff4-704f-4d15-84f5-f9a40a92fb9e-at-jetpack/api-utils/lib/unit-test.js", line 162, in assert
    this.fail(message);
  File "resource://55af4ff4-704f-4d15-84f5-f9a40a92fb9e-at-jetpack/api-utils/lib/unit-test.js", line 100, in fail
    this.console.trace();
console: [JavaScript Warning: "reference to undefined property "failure"" {file: "resource://55af4ff4-704f-4d15-84f5-f9a40a92fb9e-at-jetpack/api-utils/lib/cuddlefish.js -> resource://55af4ff4-704f-4d15-84f5-f9a40a92fb9e-at-jetpack/api-utils/lib/unit-test.js" line: 77}]
....................................
77 of 78 tests passed.
Total time: 5.753171 seconds
Program terminated unsuccessfully.
Alex, can you take a look at this for 1.4?
Assignee: nobody → poirot.alex
Priority: -- → P1
(Assignee)

Comment 2

6 years ago
Created attachment 583614 [details] [diff] [review]
Fix it

This bug is due to this platform bug 707576 (a cleanup).
nsIDOMNSElement was replaced by nsIDOMElement.
Attachment #583614 - Flags: review?(myk)
(Reporter)

Updated

6 years ago
Attachment #583614 - Flags: review?(myk) → review+

Comment 3

6 years ago
Commit pushed to https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/8cecfe3c454ad3d2279f80bf1a64728aeba89775
Bug 712463: test-content-proxy.testMozMatchedSelector fails against most
recent nightly build r=@myk
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.