Last Comment Bug 712483 - Make WinUtils
: Make WinUtils
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Widget: Win32 (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla12
Assigned To: Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28))
:
:
Mentors:
Depends on: 716819
Blocks: 672175
  Show dependency treegraph
 
Reported: 2011-12-20 15:51 PST by Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28))
Modified: 2012-01-10 00:12 PST (History)
1 user (show)
masayuki: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (97.40 KB, patch)
2011-12-21 04:00 PST, Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28))
jmathies: review+
Details | Diff | Splinter Review

Description Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28)) 2011-12-20 15:51:46 PST
Like nsCocoaUtils, we should make WinUtils in widget/src/windows.
Comment 1 Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28)) 2011-12-21 04:00:02 PST
Created attachment 583447 [details] [diff] [review]
Patch
Comment 2 Jim Mathies [:jimm] 2012-01-03 07:25:10 PST
Comment on attachment 583447 [details] [diff] [review]
Patch

Nice commenting in the header. Note, the file picker code didn't apply cleanly but it looks ok in the patch.

Also, there are recently added routines in toolkit - createItemFromParsingName & VistaCreateItemFromParsingNameInit that could also be moved here. If you don't want to add that I can do it in a follow up.

You might want to get this landed before bug 679226, I think this is going to be harder to touch up once those changes land.
Comment 3 Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28)) 2012-01-04 02:26:20 PST
landed the patch on inbound with replacing widget/src with widget.

https://hg.mozilla.org/integration/mozilla-inbound/rev/43f76a005188

jimm:

I'm on vacation until 9th Jan, so, I'd like you to do the follow up fix if you could.  Thanks.
Comment 4 Ed Morley [:emorley] 2012-01-04 17:30:03 PST
https://hg.mozilla.org/mozilla-central/rev/43f76a005188

Note You need to log in before you can comment on or make changes to this bug.