Status

()

Core
Widget: Win32
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla12
x86_64
Windows 7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

Like nsCocoaUtils, we should make WinUtils in widget/src/windows.
Created attachment 583447 [details] [diff] [review]
Patch
Attachment #583447 - Flags: review?(jmathies)

Comment 2

6 years ago
Comment on attachment 583447 [details] [diff] [review]
Patch

Nice commenting in the header. Note, the file picker code didn't apply cleanly but it looks ok in the patch.

Also, there are recently added routines in toolkit - createItemFromParsingName & VistaCreateItemFromParsingNameInit that could also be moved here. If you don't want to add that I can do it in a follow up.

You might want to get this landed before bug 679226, I think this is going to be harder to touch up once those changes land.
Attachment #583447 - Flags: review?(jmathies) → review+
landed the patch on inbound with replacing widget/src with widget.

https://hg.mozilla.org/integration/mozilla-inbound/rev/43f76a005188

jimm:

I'm on vacation until 9th Jan, so, I'd like you to do the follow up fix if you could.  Thanks.
Flags: in-testsuite-
Whiteboard: [inbound]
Target Milestone: --- → mozilla12

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/43f76a005188
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Depends on: 716819
You need to log in before you can comment on or make changes to this bug.