712510 - Clang Static Analysis: Garbage return value in content/html/content/src/nsTextEditorState.cpp

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Christian Holler (:decoder)]

The following report (in the URL field) has been generated by static analysis using Clang.

It would be good if someone familiar with the particular code could check if

- this is really a bug or a false positive
- and/or if it makes sense to adjust the code (even if there is not a real bug present, e.g. by adding a missing initialization).


In this particular report, the problem seems to be that the | nsresult rv; | variable declared in line 1173 could be returned uninitialized (there exists at least one path through the code). It would probably be good to initialize this variable to a sane default value to be sure.

Not sure which category this belongs to, please move to the right place if you know where this should go :)

Comment 1

[(no longer active)]

I don't see this happening in practice but let's just shut the warning up.  :-)

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6840cbb0b4cf

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/6840cbb0b4cf