Last Comment Bug 712584 - Properly use .def files on mingw builds
: Properly use .def files on mingw builds
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Windows 7
-- normal (vote)
: mozilla12
Assigned To: Jacek Caban
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on:
  Show dependency treegraph
Reported: 2011-12-21 02:10 PST by Jacek Caban
Modified: 2011-12-27 11:29 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix v1.0 (1.88 KB, patch)
2011-12-21 02:10 PST, Jacek Caban
khuey: review+
Details | Diff | Splinter Review

Description User image Jacek Caban 2011-12-21 02:10:41 PST
Created attachment 583431 [details] [diff] [review]
fix v1.0

When I was investigating link failure with the new gkmedias.dll, I've found that mingw lacks rules for handling DEFFILE. The attached patch adds the missing rule. Also, LD doesn't understand UTF-8 BOM in .def files, so I had to remove it from It should be harmless, I don't think there is any need for UTF-8 in .def files.
Comment 1 User image Jacek Caban 2011-12-27 01:55:30 PST
Thanks for the review.
Comment 2 User image Matt Brubeck (:mbrubeck) 2011-12-27 11:29:04 PST

Note You need to log in before you can comment on or make changes to this bug.