The default bug view has changed. See this FAQ.

Properly use .def files on mingw builds

RESOLVED FIXED in mozilla12

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla12
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 583431 [details] [diff] [review]
fix v1.0

When I was investigating link failure with the new gkmedias.dll, I've found that mingw lacks rules for handling DEFFILE. The attached patch adds the missing rule. Also, LD doesn't understand UTF-8 BOM in .def files, so I had to remove it from mozutils.def.in. It should be harmless, I don't think there is any need for UTF-8 in .def files.
Attachment #583431 - Flags: review?(khuey)
Attachment #583431 - Flags: review?(khuey) → review+
(Assignee)

Comment 1

5 years ago
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e7253322df9
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/2e7253322df9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.