Closed Bug 712584 Opened 8 years ago Closed 8 years ago

Properly use .def files on mingw builds

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla12

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
When I was investigating link failure with the new gkmedias.dll, I've found that mingw lacks rules for handling DEFFILE. The attached patch adds the missing rule. Also, LD doesn't understand UTF-8 BOM in .def files, so I had to remove it from mozutils.def.in. It should be harmless, I don't think there is any need for UTF-8 in .def files.
Attachment #583431 - Flags: review?(khuey)
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e7253322df9
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/2e7253322df9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.