Last Comment Bug 712585 - Export vpx_codec_control_ from gkmedias.dll
: Export vpx_codec_control_ from gkmedias.dll
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla12
Assigned To: Jacek Caban
:
: Maire Reavy [:mreavy]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-21 02:18 PST by Jacek Caban
Modified: 2011-12-27 11:28 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1.0 (660 bytes, patch)
2011-12-21 02:18 PST, Jacek Caban
khuey: review+
Details | Diff | Splinter Review

Description Jacek Caban 2011-12-21 02:18:08 PST
Created attachment 583432 [details] [diff] [review]
fix v1.0

vpx_codec_control_ is used by some static functions defined in vpx_codec.h. Usually, if such functions are not used, whey should be skipped by compiler. However, for some reason, it's not the case on unoptimized 64-bit mingw-w64 builds. Exporting it from gkmedias.dll will avoid similar potential problems on other builds as well.
Comment 2 Matt Brubeck (:mbrubeck) 2011-12-27 11:27:47 PST
https://hg.mozilla.org/mozilla-central/rev/ff350b65a616
Comment 3 Matt Brubeck (:mbrubeck) 2011-12-27 11:28:05 PST
I mean https://hg.mozilla.org/mozilla-central/rev/d78b7af89987

Note You need to log in before you can comment on or make changes to this bug.