Closed
Bug 712586
Opened 13 years ago
Closed 12 years ago
Make Socorro UI timezone aware
Categories
(Socorro :: Webapp, task)
Socorro
Webapp
Tracking
(Not tracked)
VERIFIED
FIXED
2.4.4
People
(Reporter: adrian, Assigned: adrian)
References
Details
Attachments
(5 files)
After we manage a way in the back-end to deal with timezones (see bug 537003), we will want to add options in the UI to select a timezone. This is mainly meant for search (/query) as it is the only place where a user can directly enter a complete datetime. Other places like daily reports could also have that option but it has less impact as one can only enter a date (definition is 1 day). Explanation about why we do this can be found in bug 537003 and bug 711233. From rhelmer in bug 711233#c2 > We just discussed in IRC, I think the clearest thing to do would be to > expose timezone in the UI, and allow it to be specified in the UI also > (whether the default should be UTC or Pacific is up for debate :) could be > hardcoded to one of these, or try to detect the browser's TZ).
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → adrian
Comment 1•13 years ago
|
||
I'm not sure how much I'd like the timezones switching around between users of the system, would be nicer to have everything just displaying the timezone that is used consistently.
Comment 2•13 years ago
|
||
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #1) > I'm not sure how much I'd like the timezones switching around between users > of the system, would be nicer to have everything just displaying the > timezone that is used consistently. I could see allowing TZ in the input (which gets converted of course) but always displaying in a consistent timezone. This might be nice-to-have but is not really the important bit. At the very minimum it seems like the Socorro UI needs to be "timezone aware" in the sense of: 1) always doing internal comparisons using consistent timezones (no more mixing up Pacific and UTC in internal calculations) 2) displaying the timezone in the UI output
Comment 3•13 years ago
|
||
So, one limitation is that I don't think we should even try to fix the timezones for oldtcbs. It would be a lot of effort for data & code we plan to depreciate.
Updated•13 years ago
|
Target Milestone: 2.4 → 2.4.1
Updated•13 years ago
|
Component: Socorro → General
Product: Webtools → Socorro
Updated•13 years ago
|
Component: General → Webapp
Assignee | ||
Updated•12 years ago
|
Target Milestone: 2.4.1 → 2.4.2
Updated•12 years ago
|
Target Milestone: 2.4.2 → 2.4.3
Assignee | ||
Comment 4•12 years ago
|
||
Opened pull request https://github.com/mozilla/socorro/pull/353 After discussing with Laura, I chose to add a note in the footer, and a (UTC) next to each date field we have in the UI. Screens will follow.
Assignee | ||
Comment 5•12 years ago
|
||
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #597479 -
Flags: review?(kairo)
Comment 7•12 years ago
|
||
Adding it in the footer and everywhere else is redundant. If TZ isn't going to be variable from date to date I don't think we need to present it in the UI at all and I'd rather close the bug without a change. If displaying it is necessary, then the status page seems more appropriate since that's where we display the other global state info of interest.
Updated•12 years ago
|
Target Milestone: 2.4.3 → 2.4.4
Comment 8•12 years ago
|
||
I disagree with lonnen here, noting the timezone is a good idea as 1) Socorro was Pacific Time earlier and 2) most other Mozilla webtools are in PT. I don't think we need to note it where it's about full days, but I agree with it in the footer, and possibly where times are displayed.
Comment 9•12 years ago
|
||
Comment on attachment 597479 [details]
Search and footer view
r+ on the parts in this screenshot.
Attachment #597479 -
Flags: review?(kairo) → review+
Assignee | ||
Comment 10•12 years ago
|
||
I just updated PR https://github.com/mozilla/socorro/pull/353 to remove the UTC note next to date fields. Now we display the timezone in the footer and next to the datetime field of the search form.
Target Milestone: 2.4.4 → 2.4.3
Assignee | ||
Updated•12 years ago
|
Target Milestone: 2.4.3 → 2.4.4
Comment 11•12 years ago
|
||
(In reply to Adrian Gaudebert [:adrian] from comment #10) > I just updated PR https://github.com/mozilla/socorro/pull/353 to remove the > UTC note next to date fields. Now we display the timezone in the footer and > next to the datetime field of the search form. Sounds good to me!
Comment 12•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/4028cfe91504e70aecb86bdb637d659b06e41c78 Merge pull request #353 from AdrianGaudebert/712586-ui-timezone-aware Fixes bug 712586 - Added the current timezone next to each date field in...
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 13•12 years ago
|
||
Steps to QA ----------- 1. Go to advanced search. 2. Check there is "UTC" written next to the "before" field. 3. Go to any page except error pages. 4. Check there is a phrase about the timezone in the footer.
Comment 14•12 years ago
|
||
Dev and stage: The utc text is not present in the advanced query before field nor in the footer.
Comment 15•12 years ago
|
||
UTC text not present in the footer.
Updated•12 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 16•12 years ago
|
||
Cron run on dev - the cause for the failure has been resolved on dev.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Comment 17•12 years ago
|
||
QA verfied on stage - :jason thx for landing the config changes.
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•