712586 - Make Socorro UI timezone aware

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[[DEACTIVATED] Adrian Gaudebert]

After we manage a way in the back-end to deal with timezones (see bug 537003), we will want to add options in the UI to select a timezone. This is mainly meant for search (/query) as it is the only place where a user can directly enter a complete datetime. Other places like daily reports could also have that option but it has less impact as one can only enter a date (definition is 1 day). 

Explanation about why we do this can be found in bug 537003 and bug 711233. 

From rhelmer in bug 711233#c2
> We just discussed in IRC, I think the clearest thing to do would be to
> expose timezone in the UI, and allow it to be specified in the UI also
> (whether the default should be UTC or Pacific is up for debate :) could be
> hardcoded to one of these, or try to detect the browser's TZ).

Comment 1

[Robert Kaiser]

I'm not sure how much I'd like the timezones switching around between users of the system, would be nicer to have everything just displaying the timezone that is used consistently.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Robert Kaiser (:[e-mail]) from comment #1)
> I'm not sure how much I'd like the timezones switching around between users
> of the system, would be nicer to have everything just displaying the
> timezone that is used consistently.

I could see allowing TZ in the input (which gets converted of course) but always displaying in a consistent timezone. This might be nice-to-have but is not really the important bit.

At the very minimum it seems like the Socorro UI needs to be "timezone aware" in the sense of:

1) always doing internal comparisons using consistent timezones (no more mixing up Pacific and UTC in internal calculations)
2) displaying the timezone in the UI output

Comment 3

[[:jberkus] Josh Berkus]

So, one limitation is that I don't think we should even try to fix the timezones for oldtcbs.  It would be a lot of effort for data & code we plan to depreciate.

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

Opened pull request https://github.com/mozilla/socorro/pull/353

After discussing with Laura, I chose to add a note in the footer, and a (UTC) next to each date field we have in the UI. Screens will follow.

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

Attachment: Daily crashes view

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

Attachment: Search and footer view

Comment 7

[Lonnen :lonnen]

Adding it in the footer and everywhere else is redundant. If TZ isn't going to be variable from date to date I don't think we need to present it in the UI at all and I'd rather close the bug without a change.

If displaying it is necessary, then the status page seems more appropriate since that's where we display the other global state info of interest.

Comment 8

[Robert Kaiser]

I disagree with lonnen here, noting the timezone is a good idea as 1) Socorro was Pacific Time earlier and 2) most other Mozilla webtools are in PT.

I don't think we need to note it where it's about full days, but I agree with it in the footer, and possibly where times are displayed.

Comment 9

[Robert Kaiser]

Comment on attachment 597479 [details]
Search and footer view

r+ on the parts in this screenshot.

Comment 10

[[DEACTIVATED] Adrian Gaudebert]

I just updated PR https://github.com/mozilla/socorro/pull/353 to remove the UTC note next to date fields. Now we display the timezone in the footer and next to the datetime field of the search form.

Comment 11

[Robert Kaiser]

(In reply to Adrian Gaudebert [:adrian] from comment #10)
> I just updated PR https://github.com/mozilla/socorro/pull/353 to remove the
> UTC note next to date fields. Now we display the timezone in the footer and
> next to the datetime field of the search form.

Sounds good to me!

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/4028cfe91504e70aecb86bdb637d659b06e41c78
Merge pull request #353 from AdrianGaudebert/712586-ui-timezone-aware

Fixes bug 712586 - Added the current timezone next to each date field in...

Comment 13

[[DEACTIVATED] Adrian Gaudebert]

Steps to QA
-----------

1. Go to advanced search.
2. Check there is "UTC" written next to the "before" field. 
3. Go to any page except error pages. 
4. Check there is a phrase about the timezone in the footer.

Comment 14

[Matt Brandt [:mbrandt]]

Attachment: qa - utc text not present

Dev and stage: The utc text is not present in the advanced query before field nor in the footer.

Comment 15

[Matt Brandt [:mbrandt]]

Attachment: qa - utc text not present

UTC text not present in the footer.

Comment 16

[Matt Brandt [:mbrandt]]

Cron run on dev - the cause for the failure has been resolved on dev.

Comment 17

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verfied on stage - :jason thx for landing the config changes.