Closed
Bug 712614
Opened 13 years ago
Closed 13 years ago
extensions.js never stops observing extensions.update.enabled
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla12
| Tracking | Status | |
|---|---|---|
| firefox10 | --- | unaffected |
| firefox11 | - | fixed |
People
(Reporter: dao, Assigned: steffen.wilberg)
References
Details
(Keywords: memory-leak, regression, Whiteboard: [MemShrink][qa-])
Attachments
(1 file)
|
1.13 KB,
patch
|
mossop
:
review+
blassey
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 710064 added a pref observer to extensions.js without ever removing it, likely keeping about:addons alive after closing it, as has been noticed in bug 658738 comment 88.
Blocks: 710064
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → steffen.wilberg
|
|
Assignee | |
Comment 2•13 years ago
|
||
Adding removeObserver call.
The other change is cleanup while I'm there - there's no second argument to removeObserver: http://mxr.mozilla.org/mozilla-central/source/modules/libpref/public/nsIPrefBranch2.idl#130
Attachment #583469 -
Flags: review?(dtownsend)
|
|
Assignee | |
Comment 3•13 years ago
|
||
And sorry for stealing your time.
|
||
Updated•13 years ago
|
Whiteboard: [MemShrink]
|
||
Updated•13 years ago
|
Attachment #583469 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
|
|
Assignee | |
Comment 6•13 years ago
|
||
Comment on attachment 583469 [details] [diff] [review]
patch
This is a regression introduced in Firefox 11, so should be fixed there as well.
Patch is trivial.
Attachment #583469 -
Flags: approval-mozilla-aurora?
This is a pretty bad leak regression with a simple fix; we should take it for 11. (It was on m-c for less than a week; just happened to hit the aurora pull dates.)
|
||
Updated•13 years ago
|
Attachment #583469 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 8•13 years ago
|
||
|
||
Updated•13 years ago
|
As there anything QA can do to verify this fix?
Whiteboard: [MemShrink] → [MemShrink][qa?]
|
Reporter | |
Comment 10•13 years ago
|
||
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #9)
> As there anything QA can do to verify this fix?
no
|
||
Comment 11•13 years ago
|
||
Thanks Dao for the quick response. qa-
Whiteboard: [MemShrink][qa?] → [MemShrink][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•