extensions.js never stops observing extensions.update.enabled

RESOLVED FIXED in Firefox 11

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dao, Assigned: Steffen Wilberg)

Tracking

({mlk, regression})

Trunk
mozilla12
mlk, regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox10 unaffected, firefox11- fixed)

Details

(Whiteboard: [MemShrink][qa-])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Bug 710064 added a pref observer to extensions.js without ever removing it, likely keeping about:addons alive after closing it, as has been noticed in bug 658738 comment 88.
(Reporter)

Updated

6 years ago
Blocks: 658738
Blocks: 710064
status-firefox10: --- → unaffected
status-firefox11: --- → affected
tracking-firefox11: --- → ?
Duplicate of this bug: 712617
(Assignee)

Updated

6 years ago
Assignee: nobody → steffen.wilberg
(Assignee)

Comment 2

6 years ago
Created attachment 583469 [details] [diff] [review]
patch

Adding removeObserver call.
The other change is cleanup while I'm there - there's no second argument to removeObserver: http://mxr.mozilla.org/mozilla-central/source/modules/libpref/public/nsIPrefBranch2.idl#130
Attachment #583469 - Flags: review?(dtownsend)
(Assignee)

Comment 3

6 years ago
And sorry for stealing your time.
Whiteboard: [MemShrink]
Attachment #583469 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/8260e9862eb5

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/8260e9862eb5
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
(Assignee)

Comment 6

6 years ago
Comment on attachment 583469 [details] [diff] [review]
patch

This is a regression introduced in Firefox 11, so should be fixed there as well.
Patch is trivial.
Attachment #583469 - Flags: approval-mozilla-aurora?
This is a pretty bad leak regression with a simple fix; we should take it for 11.  (It was on m-c for less than a week; just happened to hit the aurora pull dates.)
Attachment #583469 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 8

6 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/01432169e8fe
status-firefox11: affected → fixed

Updated

6 years ago
tracking-firefox11: ? → -
As there anything QA can do to verify this fix?
Whiteboard: [MemShrink] → [MemShrink][qa?]
(Reporter)

Comment 10

6 years ago
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #9)
> As there anything QA can do to verify this fix?

no
Thanks Dao for the quick response. qa-
Whiteboard: [MemShrink][qa?] → [MemShrink][qa-]
You need to log in before you can comment on or make changes to this bug.