Closed Bug 712614 Opened 11 years ago Closed 11 years ago

extensions.js never stops observing extensions.update.enabled

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12
Tracking Status
firefox10 --- unaffected
firefox11 - fixed

People

(Reporter: dao, Assigned: steffen.wilberg)

References

Details

(Keywords: memory-leak, regression, Whiteboard: [MemShrink][qa-])

Attachments

(1 file)

Bug 710064 added a pref observer to extensions.js without ever removing it, likely keeping about:addons alive after closing it, as has been noticed in bug 658738 comment 88.
Blocks: bc-leaks
Duplicate of this bug: 712617
Assignee: nobody → steffen.wilberg
Attached patch patchSplinter Review
Adding removeObserver call.
The other change is cleanup while I'm there - there's no second argument to removeObserver: http://mxr.mozilla.org/mozilla-central/source/modules/libpref/public/nsIPrefBranch2.idl#130
Attachment #583469 - Flags: review?(dtownsend)
And sorry for stealing your time.
Whiteboard: [MemShrink]
Attachment #583469 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/mozilla-central/rev/8260e9862eb5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Comment on attachment 583469 [details] [diff] [review]
patch

This is a regression introduced in Firefox 11, so should be fixed there as well.
Patch is trivial.
Attachment #583469 - Flags: approval-mozilla-aurora?
This is a pretty bad leak regression with a simple fix; we should take it for 11.  (It was on m-c for less than a week; just happened to hit the aurora pull dates.)
Attachment #583469 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
As there anything QA can do to verify this fix?
Whiteboard: [MemShrink] → [MemShrink][qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #9)
> As there anything QA can do to verify this fix?

no
Thanks Dao for the quick response. qa-
Whiteboard: [MemShrink][qa?] → [MemShrink][qa-]
You need to log in before you can comment on or make changes to this bug.