712617 - leaking addons manager windows until app shutdown

Status: RESOLVED DUPLICATE of bug 712614

(Toolkit :: Add-ons Manager, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fbf296760b0f adds a pref observer without removing it about 20 lines below (like the other pref observers added there are).

This seems the most likely cause of the regression dao observed in bug 658738 comment 88 (see from there through comment 91).

Dao's regression range was:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cbb0233c7ba8&tochange=be0fffc6b0d1

Since my comments there I found the following tinderbox logs cached:
https://tbpl.mozilla.org/php/getParsedLog.php?id=8084872&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=8085009&tree=Mozilla-Inbound
which show that https://tbpl.mozilla.org/?branch=mozilla-inbound&rev=61a46d539c69 was good (contradicting khuey's theory).  Looking through the remaining suspicious changes, I found the above, which seems almost certainly to be the problem.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

oops, dao and khuey beat me by a few minutes