Closed Bug 712624 Opened 11 years ago Closed 11 years ago

Permanent orange: TEST-UNEXPECTED-FAIL | test-autohide-menubar.js | test_autohidden_menubar_3pane, test_autohidden_menubar_message_window, test_autohidden_menubar_compose_window, test_autohidden_menubar_address_book

Categories

(Thunderbird :: Testing Infrastructure, defect)

Product:
Thunderbird
Component:
Testing Infrastructure
Version:
11 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird11+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 12.0
Tracking Flags:
Tracking Status
thunderbird11 + fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Patch v1
2.16 KB, patch
rain1
: review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
This test failure is a direct result of Tabs on Top landing, and is due to the fact that I changed the name of an attribute without updating a test.  Fix forthcoming.
Assignee: nobody → mconley
Blocks: tb-tabsontop
tracking-thunderbird11: --- → ?
Whiteboard: [tb-orange]
Attached patch Patch v1 — — Splinter Review 
So I failed to fix up this test once I removed the toolbarindex attribute from the menuitems.

Instead of adding the rather fragile index, I now attach the toolbar`s ID to the menuitem, and query for that in the test.
Attachment #583493 - Flags: review?(sagarwal)
Comment on attachment 583493 [details] [diff] [review]
Patch v1

yep, I think this makes sense. r+ assuming this makes tests pass.
Attachment #583493 - Flags: review?(sagarwal) → review+
Comment on attachment 583493 [details] [diff] [review]
Patch v1

The tests do indeed pass for me.  Requesting approval for landing on Aurora.
Attachment #583493 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/3118433d5808
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #583493 - Flags: approval-comm-aurora? → approval-comm-aurora+
Whiteboard: [tb-orange]
You need to log in before you can comment on or make changes to this bug.