Permanent orange: TEST-UNEXPECTED-FAIL | test-autohide-menubar.js | test_autohidden_menubar_3pane, test_autohidden_menubar_message_window, test_autohidden_menubar_compose_window, test_autohidden_menubar_address_book

RESOLVED FIXED in Thunderbird 12.0

Status

defect
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

({intermittent-failure})

11 Branch
Thunderbird 12.0
x86_64
Windows 7
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird11+ fixed)

Details

Attachments

(1 attachment)

This test failure is a direct result of Tabs on Top landing, and is due to the fact that I changed the name of an attribute without updating a test.  Fix forthcoming.
Assignee: nobody → mconley
Blocks: tb-tabsontop
Whiteboard: [tb-orange]
Posted patch Patch v1Splinter Review
So I failed to fix up this test once I removed the toolbarindex attribute from the menuitems.

Instead of adding the rather fragile index, I now attach the toolbar`s ID to the menuitem, and query for that in the test.
Attachment #583493 - Flags: review?(sagarwal)
Comment on attachment 583493 [details] [diff] [review]
Patch v1

yep, I think this makes sense. r+ assuming this makes tests pass.
Attachment #583493 - Flags: review?(sagarwal) → review+
Comment on attachment 583493 [details] [diff] [review]
Patch v1

The tests do indeed pass for me.  Requesting approval for landing on Aurora.
Attachment #583493 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/3118433d5808
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #583493 - Flags: approval-comm-aurora? → approval-comm-aurora+
Whiteboard: [tb-orange]
You need to log in before you can comment on or make changes to this bug.