Closed Bug 712624 Opened 9 years ago Closed 9 years ago
Permanent orange: TEST-UNEXPECTED-FAIL | test-autohide-menubar
.js | test _autohidden _menubar _3pane, test _autohidden _menubar _message _window, test _autohidden _menubar _compose _window, test _autohidden _menubar _address _book
This test failure is a direct result of Tabs on Top landing, and is due to the fact that I changed the name of an attribute without updating a test. Fix forthcoming.
9 years ago
So I failed to fix up this test once I removed the toolbarindex attribute from the menuitems. Instead of adding the rather fragile index, I now attach the toolbar`s ID to the menuitem, and query for that in the test.
Attachment #583493 - Flags: review?(sagarwal)
Comment on attachment 583493 [details] [diff] [review] Patch v1 yep, I think this makes sense. r+ assuming this makes tests pass.
Attachment #583493 - Flags: review?(sagarwal) → review+
Comment on attachment 583493 [details] [diff] [review] Patch v1 The tests do indeed pass for me. Requesting approval for landing on Aurora.
Attachment #583493 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/3118433d5808
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #583493 - Flags: approval-comm-aurora? → approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/ae083d2568ed
You need to log in before you can comment on or make changes to this bug.