Last Comment Bug 712624 - Permanent orange: TEST-UNEXPECTED-FAIL | test-autohide-menubar.js | test_autohidden_menubar_3pane, test_autohidden_menubar_message_window, test_autohidden_menubar_compose_window, test_autohidden_menubar_address_book
: Permanent orange: TEST-UNEXPECTED-FAIL | test-autohide-menubar.js | test_auto...
Status: RESOLVED FIXED
: intermittent-failure
Product: Thunderbird
Classification: Client Software
Component: Testing Infrastructure (show other bugs)
: 11 Branch
: x86_64 Windows 7
: -- normal (vote)
: Thunderbird 12.0
Assigned To: Mike Conley (:mconley) - (needinfo me!)
:
:
Mentors:
Depends on:
Blocks: tb-tabsontop
  Show dependency treegraph
 
Reported: 2011-12-21 06:24 PST by Mike Conley (:mconley) - (needinfo me!)
Modified: 2012-11-25 19:31 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
+
fixed


Attachments
Patch v1 (2.16 KB, patch)
2011-12-21 07:46 PST, Mike Conley (:mconley) - (needinfo me!)
sid.bugzilla: review+
standard8: approval‑comm‑aurora+
Details | Diff | Splinter Review

Description Mike Conley (:mconley) - (needinfo me!) 2011-12-21 06:24:53 PST
This test failure is a direct result of Tabs on Top landing, and is due to the fact that I changed the name of an attribute without updating a test.  Fix forthcoming.
Comment 1 Mike Conley (:mconley) - (needinfo me!) 2011-12-21 07:46:22 PST
Created attachment 583493 [details] [diff] [review]
Patch v1

So I failed to fix up this test once I removed the toolbarindex attribute from the menuitems.

Instead of adding the rather fragile index, I now attach the toolbar`s ID to the menuitem, and query for that in the test.
Comment 2 Siddharth Agarwal [:sid0] (inactive) 2011-12-21 08:07:00 PST
Comment on attachment 583493 [details] [diff] [review]
Patch v1

yep, I think this makes sense. r+ assuming this makes tests pass.
Comment 3 Mike Conley (:mconley) - (needinfo me!) 2011-12-21 08:09:28 PST
Comment on attachment 583493 [details] [diff] [review]
Patch v1

The tests do indeed pass for me.  Requesting approval for landing on Aurora.
Comment 4 Mike Conley (:mconley) - (needinfo me!) 2011-12-21 08:26:33 PST
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/3118433d5808
Comment 5 Mike Conley (:mconley) - (needinfo me!) 2011-12-21 14:18:57 PST
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/ae083d2568ed

Note You need to log in before you can comment on or make changes to this bug.