712639 - Firefox Sync setup strings do not match Fennec XUL

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Chenxia Liu [:liuche]]

On setting up sync, text incorrectly reads "Add a Device" instead of "Pair a Device." Check other strings as well.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: V1: fixed incorrect strings (compared with Fennec XUL 12)

There are some differences with post-sync messages, such as going to "Settings" to modify syncable contentProviders.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 583486 [details] [diff] [review]
V1: fixed incorrect strings (compared with Fennec XUL 12)

Review of attachment 583486 [details] [diff] [review]:
-----------------------------------------------------------------

::: sync_strings.dtd.in
@@ +28,4 @@
>    
>  <!-- Setup Fail -->
>  <!ENTITY sync.title.fail.label 'Cannot Set Up &syncBrand.shortName.label;'>
> +<!ENTITY sync.subtitle.fail.label '&syncBrand.fullName.label; could not connect to the Sync. Would you like to try again?'>

Pretty sure "Firefox Sync could not connect to the Sync" ain't right.

Comment 3

[Richard Newman [:rnewman]]

Fixed and pushed:

https://github.com/mozilla-services/android-sync/commit/92c4aa70bd6ca9e53fbf6694c015e0d6c7b361f5

Comment 4

[Chenxia Liu [:liuche]]

Attachment: V2: added Firefox brand string.

Whoops, should be "Firefox cannot connect to Sync."

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 583572 [details] [diff] [review]
V2: added Firefox brand string.

Eh, fixed already. GOOD ENOUGH. :D