712661 - [sq] Search Engine modification for Thunderbird

Status: RESOLVED FIXED

(Mozilla Localizations :: sq / Albanian, defect)

Description

[Besnik Bleta]

Attachment: Patch

Hello Mark,

Following the steps required for my last sign-off, here is the patch for region.properties.
The other file is just copied from the original.

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 583507 [details] [diff] [review]
Patch

r=Standard8

Please land this on aurora and beta, and update your sign-offs for both of those channels.

Please also leave this bug open for doing the locale specific search engines when you're ready.

Comment 2

[Mark Banner (:standard8)]

Hi, the final beta is in a few days, please don't forget to land this and update your sign-offs. If you need help let me know.

Comment 3

[Mark Banner (:standard8)]

(In reply to Mark Banner (:standard8) from comment #2)
> Hi, the final beta is in a few days, please don't forget to land this and
> update your sign-offs. If you need help let me know.

Just to clarify, I've just signed you off on aurora, but we need to get this patch on beta and signed-off as well.

Comment 4

[Besnik Bleta]

Attachment: Patching sq/mail/searchplugins/wikipedia.xml

Comment 5

[Besnik Bleta]

Attachment: Patching sq/mail/searchplugins/list.txt

Comment 6

[Besnik Bleta]

Hello Mark,

I'll land that for beta too. Meanwhile, could you review the two patches relates to sq/mail/searchplugins  please? (Attachments 581961, 589162 above.)

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 589161 [details] [diff] [review]
Patching sq/mail/searchplugins/wikipedia.xml

I think you probably want to update the ShortName and Description of this, as at the moment the ShortName will reference en, and the description is in English.

If you could attach the full wikipedia-sq.xml file with those changes so I can just check it through before we land it, that'd be great.

Also, as you're not shipping with bing in list.txt you'll need to remove this line from mail/chrome/messenger-chrome/region.properties:

browser.search.order.3=Bing

Comment 8

[Besnik Bleta]

Attachment: Proposed wikipedia-sq.xml

Here you are wikipedia-sq.xml

Comment 9

[Besnik Bleta]

Attachment: Patching sq/mail/searchplugins/list.txt

Let put the Bing back. Easier.