712748 - Save Image of JPEG files appends extra ".jpeg" filename extension (e.g. "example.jpg.jpeg")

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Load http://www.jpeg.org (or any website with an embedded .jpg image).
2. Long-press on the big blue image.
3. From the popup menu, select "Save Image".

AR:
The downloaded file's name adds a redundant ".jpeg" filename extension, such as "example.jpg.jpeg".

ER:
The downloaded file should be named "example.jpg".

NOTE:
Downloading .gif and .png files works as expected. The downloaded files do not have redundant filename extensions.

Comment 1

[Adrian Tamas (:AdrianT)]

Issue is still reproducible on Firefox Native 14.0 beta 1 on HTC Desire running Android 2.2

Comment 2

[Ian Patterson]

Attachment: Belongs in 'objdir-droid/dist/bin/chrome/toolkit/content/global/'

Added a return statement to line 1009 in an existing try/catch statement (checks if the save target has an extension instead of assigning a new one).

Comment 3

[Aaron Train [:aaronmt]]

Hi Ian,

You will need to submit an attachment as a patch (https://developer.mozilla.org/en/docs/Creating_a_patch)

Comment 4

[Ian Patterson]

Attachment: Included a return statement for a urlext try/catch

Re-uploading changes in patch form.

Comment 5

[Chris Peterson [:cpeterson]]

Comment on attachment 688457 [details] [diff] [review]
Included a return statement for a urlext try/catch

Review of attachment 688457 [details] [diff] [review]:
-----------------------------------------------------------------

Ian, because this bug only affects Android, I think the bug fix will most likely be in Android's js files in mobile-central/mobile/android/base/. The contentAreaUtils.js file is shared with the Firefox desktop browser.

::: toolkit/content/contentAreaUtils.js
@@ +1001,5 @@
>    var urlext;
>    try {
>      url = aURI.QueryInterface(Components.interfaces.nsIURL);
>      urlext = url.fileExtension;
> +    return urlext;

What is the value of the urlext variable? Something like "jpg"? If that extension value existed in mimeInfo, then mimeInfo.extensionExists(urlext) would return true (below) and this function would return urlext.

@@ +1006,5 @@
>    } catch (e) {
>    }
>  
>    if (urlext && mimeInfo && mimeInfo.extensionExists(urlext)) {
>      return urlext;

I suspect that getMIMEInfoForType(aContentType, ext) returned a mimeInfo that does not recognize urlext. Perhaps our Android code is passing a aContentType parameter to the getDefaultExtension() function that does not make sense for .jpg files? Note that this Android bug affects .jpg files, but not .gif or .png files.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 688457 [details] [diff] [review]
Included a return statement for a urlext try/catch

Looks like we need answers to cpeterson's questions here - cancelling the review request.

Comment 7

[Ian Patterson]

Attachment: nsMIMEInfoAndroid::ExtensionExists rewritten to check if requested mimeType exists.

Comment 8

[Chris Peterson [:cpeterson]]

Comment on attachment 691891 [details] [diff] [review]
nsMIMEInfoAndroid::ExtensionExists rewritten to check if requested mimeType exists.

Review of attachment 691891 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Comment 9

[Chris Peterson [:cpeterson]]

Green try test:
https://tbpl.mozilla.org/?tree=Try&rev=411c3e473a4f

Comment 10

[Chris Peterson [:cpeterson]]

Thanks, Ian! I checked your patch into mercurial for Firefox 20:

https://hg.mozilla.org/integration/mozilla-inbound/rev/11e520752312

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11e520752312

Comment 12

[Ioana Chiorean]

Firefox 20.0a1 (2012-12-17)
Device: Galaxy Nexus
OS: Android 4.1.1

Downloading a picture from jpeg.com it is saved with correct extension. Marking bug as VERIFIED FIXED.