Closed
Bug 712754
Opened 12 years ago
Closed 12 years ago
Send profile-before-change in test_nsIDownloadHistory.js
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: espindola, Assigned: espindola)
Details
Attachments
(1 file, 1 obsolete file)
842 bytes,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
This makes sure the connection is closed. Not sure if there a more general "shudown places" routine we could use in this test.
Assignee | ||
Comment 1•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=400a4c81d8cb
Comment 2•12 years ago
|
||
if the test correctly invokes do_get_profile (as it should) it will get profile-before-change...
Comment 3•12 years ago
|
||
so looks like it doesn't, you should just make so that the test on start invokes do_get_profile() to properly create a profile.
Assignee | ||
Comment 4•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=819f4485f973
Attachment #583608 -
Attachment is obsolete: true
Attachment #583608 -
Flags: review?(mak77)
Attachment #583848 -
Flags: review?(mak77)
Comment 5•12 years ago
|
||
Comment on attachment 583848 [details] [diff] [review] Call do_get_profile. Review of attachment 583848 [details] [diff] [review]: ----------------------------------------------------------------- Maybe add a comment above stating that it's needed to properly setup and shutdown the profile.
Attachment #583848 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=97df9986ccf4
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/97df9986ccf4
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•