712754 - Send profile-before-change in test_nsIDownloadHistory.js

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

This makes sure the connection is closed. Not sure if there a more general "shudown places" routine we could use in this test.

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Send profile-before-change in test_nsIDownloadHistory.js

https://tbpl.mozilla.org/?tree=Try&rev=400a4c81d8cb

Comment 2

[Marco Bonardo [:mak]]

if the test correctly invokes do_get_profile (as it should) it will get profile-before-change...

Comment 3

[Marco Bonardo [:mak]]

so looks like it doesn't, you should just make so that the test on start invokes do_get_profile() to properly create a profile.

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Call do_get_profile.

https://tbpl.mozilla.org/?tree=Try&rev=819f4485f973

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 583848 [details] [diff] [review]
Call do_get_profile.

Review of attachment 583848 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe add a comment above stating that it's needed to properly setup and shutdown the profile.

Comment 6

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=97df9986ccf4

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/97df9986ccf4