712765 - gcc warning in nsIDOMXULMultSelectCntrlEl.h: overloaded virtual

Status: NEW

(Core :: XUL, defect)

Description

[Hubert Figuiere [:hub]]

gcc show the following warning.

In file included from /home/hub/source/mozilla/src/content/base/src/../../xul/content/src/nsXULElement.h:61:0,
                 from /home/hub/source/mozilla/src/content/base/src/nsStyledElement.cpp:54:
../../../dist/include/nsIDOMXULSelectCntrlEl.h:33:60: warning: ‘virtual nsresult nsIDOMXULSelectControlElement::GetSelectedItem(nsIDOMXULSelectControlItemElement**)’ was hidden [-Woverloaded-virtual]
../../../dist/include/nsIDOMXULMultSelectCntrlEl.h:73:60: warning:   by ‘virtual nsresult nsIDOMXULMultiSelectControlElement::GetSelectedItem(PRInt32, nsIDOMXULSelectControlItemElement**)’ [-Woverloaded-virtual]
nsXULElement.cpp


This prevent the a11y module to compile warning free.

I will attach a patch.

Comment 1

[Hubert Figuiere [:hub]]

Attachment: patch

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 583622 [details] [diff] [review]
patch

If you want your patch looked at you should probably request review from the relevent module owner / peers, which in this case would appear to be toolkit::XUL_Language, so look at https://wiki.mozilla.org/Modules/Toolkit#XUL_Language

That said this patch is clearly broken since it doesn't change an interface uuid when modifying it in ways that will cause a vtable to change, and it doesn't change anything that implements the interface.

Comment 3

[Hubert Figuiere [:hub]]

Comment on attachment 583622 [details] [diff] [review]
patch

This patch is utterly broken. Will submit a new one.