Closed Bug 712808 Opened 9 years ago Closed 9 years ago

[ICS] URL bar loses values on rotation

Categories

(Firefox for Android :: General, defect, P2)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 12
Tracking Status
firefox11 --- verified
firefox12 --- verified
fennec 11+ ---

People

(Reporter: sriram, Assigned: sriram)

References

Details

Attachments

(1 file)

Bug 712477 refreshed the display, but didn't set the values on the URL bar.
Attached patch PatchSplinter Review
This patch reloads the values if available.
Assignee: nobody → sriram
Attachment #583662 - Flags: review?(mark.finkle)
Blocks: 712477
Priority: -- → P2
Hardware: All → ARM
Duplicate of this bug: 715901
Comment on attachment 583662 [details] [diff] [review]
Patch

>+
>+                Tab tab = Tabs.getInstance().getSelectedTab();
>+                if (tab != null) {
>+                    mBrowserToolbar.setTitle(tab.getDisplayTitle());
>+                    mBrowserToolbar.setFavicon(tab.getFavicon());
>+                    mBrowserToolbar.setSecurityMode(tab.getSecurityMode());
>+                    mBrowserToolbar.setProgressVisibility(tab.isLoading());
>+                    mBrowserToolbar.setShadowVisibility(!(tab.getURL().startsWith("about:")));
>+                    mBrowserToolbar.updateTabs(Tabs.getInstance().getCount());
>+                }

We reuse this coding pattern in a few places. We should add a method to BrowserToolbar to simplify this. Maybe BrowserToolbar.updateFromTab(Tab)  ?

I'll file a bug for that
Attachment #583662 - Flags: review?(mark.finkle) → review+
tracking-fennec: --- → 11+
We will need this on aurora to complete bug 712477, which should also hit aurora
https://hg.mozilla.org/mozilla-central/rev/7fc3617ee1e5
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Attachment #583662 - Flags: approval-mozilla-aurora?
Comment on attachment 583662 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #583662 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified on M-A & M-C
Galaxy Nexus (Android 4.0.3)

20120126053754
http://hg.mozilla.org/releases/mozilla-aurora/rev/9d5ede8cb11a

20120126031113
http://hg.mozilla.org/mozilla-central/rev/402b394b6623
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.