712808 - [ICS] URL bar loses values on rotation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Sriram Ramasubramanian [:sriram]]

Bug 712477 refreshed the display, but didn't set the values on the URL bar.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch reloads the values if available.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 583662 [details] [diff] [review]
Patch

>+
>+                Tab tab = Tabs.getInstance().getSelectedTab();
>+                if (tab != null) {
>+                    mBrowserToolbar.setTitle(tab.getDisplayTitle());
>+                    mBrowserToolbar.setFavicon(tab.getFavicon());
>+                    mBrowserToolbar.setSecurityMode(tab.getSecurityMode());
>+                    mBrowserToolbar.setProgressVisibility(tab.isLoading());
>+                    mBrowserToolbar.setShadowVisibility(!(tab.getURL().startsWith("about:")));
>+                    mBrowserToolbar.updateTabs(Tabs.getInstance().getCount());
>+                }

We reuse this coding pattern in a few places. We should add a method to BrowserToolbar to simplify this. Maybe BrowserToolbar.updateFromTab(Tab)  ?

I'll file a bug for that

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7fc3617ee1e5

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

We will need this on aurora to complete bug 712477, which should also hit aurora

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7fc3617ee1e5

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 583662 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ffeb7909307f

Comment 9

[Aaron Train [:aaronmt]]

Verified on M-A & M-C
Galaxy Nexus (Android 4.0.3)

20120126053754
http://hg.mozilla.org/releases/mozilla-aurora/rev/9d5ede8cb11a

20120126031113
http://hg.mozilla.org/mozilla-central/rev/402b394b6623