71286 - PSM2 won't build because of string stuff

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Boris Zbarsky [:bzbarsky]]

When I try to build PSM2 (pull around 4am PST on 2001-03-08), I get errors
because a bunch of NS_LITERAL_STRINGs need a .get().  So no PSM2

Attaching a diff that adds all the get() calls.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Add lots of get() calls

Comment 2

[Peter "jag" Annema]

Looks good. r=jag. Can someone who also builds PSM2 confirm that this fixes all
of it?

Comment 3

[Gregory McLean]

I tested this patch and it works as expected, psm2 still don't build for me but
thats a different error.

Comment 4

[Girish Manwani]

The list of files is incomplete. I also get the error in 

nsPSMUICallbacks.cpp
CC -library=iostream -o nsPSMUICallbacks.o -c -DOSTYPE=\"SunOS5\" -DOJI  
-I../../../dist/include -I../../../dist/include      -I. 
-I/usr/openwin/include   -KPIC  -xO3 -mt -O  -DNDEBUG -DTRIMMED -DMOZILLA_CLIENT
-DBROKEN_QSORT=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DD_INO=d_ino
-DMOZ_WIDGET_GTK=1 -DMOZ_ENABLE_XREMOTE=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk\"
-DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1
-DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1
-DHAVE_DIRENT_H=1 -DHAVE_SYS_BYTEORDER_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1
-DHAVE_SYS_FILIO_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_SYS_MOUNT_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1
-DHAVE_LIBSOCKET=1 -DHAVE_LIBPOSIX4=1 -D_REENTRANT=1 -DHAVE_RANDOM=1
-DHAVE_QSORT=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1
-DHAVE_SNPRINTF=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STATVFS=1 -DHAVE_MEMMOVE=1
-DHAVE_USLEEP=1 -DHAVE_RINT=1 -DHAVE_GETTIMEOFDAY=1 -DGETTIMEOFDAY_TWO_ARGS=1
-DHAVE_DEV_ZERO=1 -DHAVE_IOS_BINARY=1 -DHAVE_OSTREAM=1 -DHAVE_CPP_EXPLICIT=1
-DHAVE_CPP_SPECIALIZATION=1 -DHAVE_CPP_MODERN_SPECIALIZE_TEMPLATE_SYNTAX=1
-DHAVE_CPP_PARTIAL_SPECIALIZATION=1 -DHAVE_CPP_ACCESS_CHANGING_USING=1
-DHAVE_CPP_AMBIGUITY_RESOLVING_USING=1 -DHAVE_CPP_NAMESPACE_STD=1
-DHAVE_CPP_UNAMBIGUOUS_STD_NOTEQUAL=1 -DHAVE_CPP_NEW_CASTS=1
-DHAVE_CPP_DYNAMIC_CAST_TO_VOID_PTR=1 -DHAVE_I18N_LC_MESSAGES=1
-DMOZ_MAIL_NEWS=1 -DMOZ_ENDER_LITE=1 -DNS_MT_SUPPORTED=1
-DCPP_CV_QUALIFIERS_CAUSE_AMBIGUITY=1 -DMOZ_USER_DIR=\".mozilla\" -DMOZ_XUL=1
-DINCLUDE_XUL=1 -DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1
-DHAVE_MOVEMAIL=1 -DJS_THREADSAFE=1  nsPSMUICallbacks.cpp
"nsPSMUICallbacks.cpp", line 417: Error: Cannot cast from NS_ConvertASCIItoUCS2
to const unsigned short*.
"nsPSMUICallbacks.cpp", line 421: Warning: The variable value has not yet been
assigned a value.
1 Error(s) and 1 Warning(s) detected.
gmake[3]: *** [nsPSMUICallbacks.o] Error 1

Comment 5

[Boris Zbarsky [:bzbarsky]]

javi, I was just looking and it looks like you've updated all those strings... 
Is this resolved now?

Girish, jag checked in a patch for the file you mention already

Comment 6

[Javier Delgadillo]

this should be fixed now.

Comment 7

[John Unruh]

Verified per javier's comments.