712867 - Orion is white-on-white when using High Contrast Black color scheme

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect)

Description

[Jason Barnabe (np)]

Using Windows 7:

1. Set the Windows color scheme to "High Contrast Black"
2. Set devtools.editor.component to "orion"
3. Open Scratchpad
4. Type some text

Scratchpad shows the text as white on white (or white on light blue when the line is selected).

Comment 1

[Paul Rouget [:paul]]

Is that still true in Firefox Aurora 11 (or Firefox Nightly)?

Comment 2

[Jason Barnabe (np)]

Problem also occurs in 12.0a1 (2011-12-23) on Windows 7.

Comment 3

[Paul Rouget [:paul]]

(In reply to Jason Barnabe (np) from comment #2)
> Problem also occurs in 12.0a1 (2011-12-23) on Windows 7.

Can I get a screenshot please?

Comment 4

[Paul Rouget [:paul]]

Attachment: patch v1

Comment 5

[Paul Rouget [:paul]]

Comment on attachment 585427 [details] [diff] [review]
patch v1

Use black by default.

Comment 6

[Mihai Sucan [:msucan]]

Comment on attachment 585427 [details] [diff] [review]
patch v1

Review of attachment 585427 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.

Did you test the patch on Windows 7 with the High Contrast Black color scheme?

Comment 7

[Paul Rouget [:paul]]

(In reply to Mihai Sucan [:msucan] from comment #6)
> Comment on attachment 585427 [details] [diff] [review]
> patch v1
> 
> Review of attachment 585427 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks fine to me.
> 
> Did you test the patch on Windows 7 with the High Contrast Black color
> scheme?

yes. Thx for the r+.

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/ab192fefef70

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/ab192fefef70