Use stdint for HAL

RESOLVED FIXED in mozilla15

Status

()

Core
Hardware Abstraction Layer (HAL)
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
We've got mozilla/StdInt.h now, so we should use it.
(Assignee)

Comment 1

5 years ago
Created attachment 625927 [details] [diff] [review]
Patch v1
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #625927 - Flags: review?(jones.chris.g)
Attachment #625927 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 2

5 years ago
Thanks!

https://hg.mozilla.org/mozilla-central/rev/fb91158d8c9a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Surprise! You broke my builds :) 
http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/403/steps/build/logs/stdio

hal/sandbox/SandboxHal.cpp:46: error: no matching function for call to 'mozilla::hal_sandbox::PHalChild::SendVibrate(AutoInfallibleTArray<unsigned int, 8u>&, const InfallibleTArray<long long unsigned int>&, mozilla::dom::TabChild*)'
../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalChild.h:113: note: candidates are: bool mozilla::hal_sandbox::PHalChild::SendVibrate(const InfallibleTArray<unsigned int>&, const InfallibleTArray<long unsigned int>&, mozilla::dom::PBrowserChild*)

hal/sandbox/SandboxHal.cpp:56: error: no matching function for call to 'mozilla::hal_sandbox::PHalChild::SendCancelVibrate(const InfallibleTArray<long long unsigned int>&, mozilla::dom::TabChild*)'
../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalChild.h:118: note: candidates are: bool mozilla::hal_sandbox::PHalChild::SendCancelVibrate(const InfallibleTArray<long unsigned int>&, mozilla::dom::PBrowserChild*)

../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalParent.h: At global scope:
../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalParent.h:77: warning: 'virtual bool mozilla::hal_sandbox::PHalParent::RecvVibrate(const InfallibleTArray<unsigned int>&, const InfallibleTArray<long unsigned int>&, mozilla::dom::PBrowserParent*)' was hidden
hal/sandbox/SandboxHal.cpp:275: warning:   by 'virtual bool mozilla::hal_sandbox::HalParent::RecvVibrate(const InfallibleTArray<unsigned int>&, const InfallibleTArray<long long unsigned int>&, mozilla::dom::PBrowserParent*)'

../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalParent.h:81: warning: 'virtual bool mozilla::hal_sandbox::PHalParent::RecvCancelVibrate(const InfallibleTArray<long unsigned int>&, mozilla::dom::PBrowserParent*)' was hidden
hal/sandbox/SandboxHal.cpp:301: warning:   by 'virtual bool mozilla::hal_sandbox::HalParent::RecvCancelVibrate(const InfallibleTArray<long long unsigned int>&, mozilla::dom::PBrowserParent*)'

hal/sandbox/SandboxHal.cpp:601: error: cannot allocate an object of abstract type 'mozilla::hal_sandbox::HalParent'
hal/sandbox/SandboxHal.cpp:270: note:   because the following virtual functions are pure within 'mozilla::hal_sandbox::HalParent':
../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalParent.h:77: note: 	virtual bool mozilla::hal_sandbox::PHalParent::RecvVibrate(const InfallibleTArray<unsigned int>&, const InfallibleTArray<long unsigned int>&, mozilla::dom::PBrowserParent*)
../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalParent.h:81: note: 	virtual bool mozilla::hal_sandbox::PHalParent::RecvCancelVibrate(const InfallibleTArray<long unsigned int>&, mozilla::dom::PBrowserParent*)

As usual, int64 != int64_t.....
Wild guess, it seems it breaks because sandbox/PHal.ipdl uses uint32/uint64 when declaring Vibrate & CancelVibrate.
Created attachment 627446 [details] [diff] [review]
Use  stdint tyles in PHal.pidl too

Easy fix, still building but went through hal/ at least.
Attachment #627446 - Flags: review?(Ms2ger)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

5 years ago
Comment on attachment 627446 [details] [diff] [review]
Use  stdint tyles in PHal.pidl too

Review of attachment 627446 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about that.
Attachment #627446 - Flags: review?(Ms2ger) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ea78fb21a20
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9ea78fb21a20
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.