712910 - Use stdint for HAL

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

We've got mozilla/StdInt.h now, so we should use it.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks!

https://hg.mozilla.org/mozilla-central/rev/fb91158d8c9a

Comment 3

[Landry Breuil (:gaston)]

Surprise! You broke my builds :) 
http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/403/steps/build/logs/stdio

hal/sandbox/SandboxHal.cpp:46: error: no matching function for call to 'mozilla::hal_sandbox::PHalChild::SendVibrate(AutoInfallibleTArray<unsigned int, 8u>&, const InfallibleTArray<long long unsigned int>&, mozilla::dom::TabChild*)'
../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalChild.h:113: note: candidates are: bool mozilla::hal_sandbox::PHalChild::SendVibrate(const InfallibleTArray<unsigned int>&, const InfallibleTArray<long unsigned int>&, mozilla::dom::PBrowserChild*)

hal/sandbox/SandboxHal.cpp:56: error: no matching function for call to 'mozilla::hal_sandbox::PHalChild::SendCancelVibrate(const InfallibleTArray<long long unsigned int>&, mozilla::dom::TabChild*)'
../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalChild.h:118: note: candidates are: bool mozilla::hal_sandbox::PHalChild::SendCancelVibrate(const InfallibleTArray<long unsigned int>&, mozilla::dom::PBrowserChild*)

../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalParent.h: At global scope:
../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalParent.h:77: warning: 'virtual bool mozilla::hal_sandbox::PHalParent::RecvVibrate(const InfallibleTArray<unsigned int>&, const InfallibleTArray<long unsigned int>&, mozilla::dom::PBrowserParent*)' was hidden
hal/sandbox/SandboxHal.cpp:275: warning:   by 'virtual bool mozilla::hal_sandbox::HalParent::RecvVibrate(const InfallibleTArray<unsigned int>&, const InfallibleTArray<long long unsigned int>&, mozilla::dom::PBrowserParent*)'

../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalParent.h:81: warning: 'virtual bool mozilla::hal_sandbox::PHalParent::RecvCancelVibrate(const InfallibleTArray<long unsigned int>&, mozilla::dom::PBrowserParent*)' was hidden
hal/sandbox/SandboxHal.cpp:301: warning:   by 'virtual bool mozilla::hal_sandbox::HalParent::RecvCancelVibrate(const InfallibleTArray<long long unsigned int>&, mozilla::dom::PBrowserParent*)'

hal/sandbox/SandboxHal.cpp:601: error: cannot allocate an object of abstract type 'mozilla::hal_sandbox::HalParent'
hal/sandbox/SandboxHal.cpp:270: note:   because the following virtual functions are pure within 'mozilla::hal_sandbox::HalParent':
../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalParent.h:77: note: 	virtual bool mozilla::hal_sandbox::PHalParent::RecvVibrate(const InfallibleTArray<unsigned int>&, const InfallibleTArray<long unsigned int>&, mozilla::dom::PBrowserParent*)
../ipc/ipdl/_ipdlheaders/mozilla/hal_sandbox/PHalParent.h:81: note: 	virtual bool mozilla::hal_sandbox::PHalParent::RecvCancelVibrate(const InfallibleTArray<long unsigned int>&, mozilla::dom::PBrowserParent*)

As usual, int64 != int64_t.....

Comment 4

[Landry Breuil (:gaston)]

Wild guess, it seems it breaks because sandbox/PHal.ipdl uses uint32/uint64 when declaring Vibrate & CancelVibrate.

Comment 5

[Landry Breuil (:gaston)]

Attachment: Use stdint tyles in PHal.pidl too

Easy fix, still building but went through hal/ at least.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 627446 [details] [diff] [review]
Use  stdint tyles in PHal.pidl too

Review of attachment 627446 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about that.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ea78fb21a20

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9ea78fb21a20