If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Allow banners from locales even if entire site isn't available in that locale.

VERIFIED FIXED

Status

Firefox Affiliates Graveyard
affiliates.mozilla.org
VERIFIED FIXED
6 years ago
2 years ago

People

(Reporter: chelsea, Assigned: mkelly)

Tracking

Details

(Whiteboard: [dev][release:2])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Make it possible for there to be buttons for a given locale even if the entire site isn't available in that locale. Meaning a user could also choose buttons outside of their locale (eg. an english user could pick a chinese button).
(Assignee)

Updated

6 years ago
Summary: [Affiliates] Allow users to choose buttons outside of their locale → Allow banners from locales even if entire site isn't available in that locale.
Whiteboard: [dev]
(Reporter)

Comment 1

6 years ago
mkelly, it looks like this is live and working. Are we good to close?
(Assignee)

Comment 2

6 years ago
This isn't live. We currently only allow banners in locales that the site is already available in; for example, we can't launch banners in zh-CN because the site isn't localized in that locale yet.
(Reporter)

Comment 3

6 years ago
Gotcha. I misunderstood and now that you point that out, I totally remember. Sorry and thanks!
(Assignee)

Updated

5 years ago
Assignee: nobody → mkelly
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Whiteboard: [dev] → [dev][release:2]

Comment 4

5 years ago
Commit pushed to develop at https://github.com/mozilla/affiliates

https://github.com/mozilla/affiliates/commit/88a19c21b232bfdcce1c1f25b3102d31bd40828a
Allow BannerImages in any locale + English labels.

Changes LocaleField to allow any locale defined in product_details
to be used, making it possible to add BannerImages from locales
that the site has yet to be translated in.

In addition, this uses a custom ModelForm on every ModelAdmin object
across the site to change the labels for LocaleFields in the admin
interface to use English labels instead of localized labels.

fix bug 713041

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Created attachment 633270 [details]
qa - verified

QA verified on stage - buttons for locals other than the user's env are available.

Updated

5 years ago
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All
Product: Websites → Firefox Affiliates
Product: Firefox Affiliates → Firefox Affiliates Graveyard
You need to log in before you can comment on or make changes to this bug.