713041 - Allow banners from locales even if entire site isn't available in that locale.

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)

Description

[Chelsea Novak [:chelsea]]

Make it possible for there to be buttons for a given locale even if the entire site isn't available in that locale. Meaning a user could also choose buttons outside of their locale (eg. an english user could pick a chinese button).

Comment 1

[Chelsea Novak [:chelsea]]

mkelly, it looks like this is live and working. Are we good to close?

Comment 2

[Osmose [:osmose, :mkelly]]

This isn't live. We currently only allow banners in locales that the site is already available in; for example, we can't launch banners in zh-CN because the site isn't localized in that locale yet.

Comment 3

[Chelsea Novak [:chelsea]]

Gotcha. I misunderstood and now that you point that out, I totally remember. Sorry and thanks!

Comment 4

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/affiliates

https://github.com/mozilla/affiliates/commit/88a19c21b232bfdcce1c1f25b3102d31bd40828a
Allow BannerImages in any locale + English labels.

Changes LocaleField to allow any locale defined in product_details
to be used, making it possible to add BannerImages from locales
that the site has yet to be translated in.

In addition, this uses a custom ModelForm on every ModelAdmin object
across the site to change the labels for LocaleFields in the admin
interface to use English labels instead of localized labels.

fix bug 713041

Comment 5

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verified on stage - buttons for locals other than the user's env are available.