713058 - Polish tabs-on-top theme on Windows XP

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Richard Marti (:Paenglab)]

Some little changes to make TB look better under Windows XP after landing of Bug 644169

Comment 1

[Richard Marti (:Paenglab)]

Attachment: XP polish

This patch fixes following:
Change the mail-toolbox definition from ID to class to apply also on the Lightning toolboxes (Bug 709572).

Let the text-shadow on active tabs with Personas (like Bug 710838).

Remove the double border in standalone window and remove the gradient.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Standalone window comparison with before and after the patch

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Personas tab comparison. Top is before the patch

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 583887 [details] [diff] [review]
XP polish

I mostly like it, and the code seems fine, so r=me, and ui-r=me, although I wonder how that'll look when the un-bolding-of-the-active-tab-title patch lands…

Comment 5

[Richard Marti (:Paenglab)]

It looks the patch is only for (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #4)
> Comment on attachment 583887 [details] [diff] [review]
> XP polish
> 
> I mostly like it, and the code seems fine, so r=me, and ui-r=me, although I
> wonder how that'll look when the un-bolding-of-the-active-tab-title patch
> lands…

It looks the un-bolding-of-the-active-tab-title patch is only for Gnomestripe and Aero. Should I add it here?

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Yeah, I think so.  I would also suggest removing it in Mac, but I don't think we do anything special to the active tab there…

Thanks,
Blake.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: XP polish v2

Because I've added the removing of the bolding of the active tab I'm asking again for review.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Comparison between bold and normal active tab

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 584074 [details] [diff] [review]
XP polish v2

Yeah, that looks more consistent with our other platforms.  ui-r=me.

>+++ b/mail/themes/qute/mail/messageWindow.css
>@@ -51,6 +51,10 @@
>+#mail-toolbox {

So, here we're adding "#mail-toolbox"

>+++ b/mail/themes/qute/mail/primaryToolbar.css
>@@ -63,14 +63,15 @@
>-#mail-toolbox {
>+.mail-toolbox {

But here we're changing "#mail-toolbox" to ".mail-toolbox"…

Other than that I like it, so if you can fix (or explain) that inconsistency, r=me, too.  :)

Thanks,
Blake.

Comment 10

[Richard Marti (:Paenglab)]

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #9)
> Comment on attachment 584074 [details] [diff] [review]
> XP polish v2
> 
> Yeah, that looks more consistent with our other platforms.  ui-r=me.
> 
> >+++ b/mail/themes/qute/mail/messageWindow.css
> >@@ -51,6 +51,10 @@
> >+#mail-toolbox {
> 
> So, here we're adding "#mail-toolbox"
> 
> >+++ b/mail/themes/qute/mail/primaryToolbar.css
> >@@ -63,14 +63,15 @@
> >-#mail-toolbox {
> >+.mail-toolbox {
> 
> But here we're changing "#mail-toolbox" to ".mail-toolbox"…

The change to class is for Lightning and other Add-ons which want use this toolbox in their tabs.

In standalone window (messageWindow.css) I've used the ID to be the most powerful rule and I haven't to use !important. And here we don't need to be compatible with Lightning.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/dcd9503ca698

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/e432f4f1d797