Closed Bug 713058 Opened 9 years ago Closed 9 years ago

Polish tabs-on-top theme on Windows XP

Categories

(Thunderbird :: Toolbars and Tabs, defect)

12 Branch
All
Windows XP
defect
Not set
normal

Tracking

(thunderbird11 fixed)

RESOLVED FIXED
Thunderbird 12.0
Tracking Status
thunderbird11 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(4 files, 1 obsolete file)

Some little changes to make TB look better under Windows XP after landing of Bug 644169
Blocks: tb-tabsontop
Attached patch XP polish (obsolete) — Splinter Review
This patch fixes following:
Change the mail-toolbox definition from ID to class to apply also on the Lightning toolboxes (Bug 709572).

Let the text-shadow on active tabs with Personas (like Bug 710838).

Remove the double border in standalone window and remove the gradient.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #583887 - Flags: ui-review?(bwinton)
Attachment #583887 - Flags: review?(bwinton)
Comment on attachment 583887 [details] [diff] [review]
XP polish

I mostly like it, and the code seems fine, so r=me, and ui-r=me, although I wonder how that'll look when the un-bolding-of-the-active-tab-title patch lands…
Attachment #583887 - Flags: ui-review?(bwinton)
Attachment #583887 - Flags: ui-review+
Attachment #583887 - Flags: review?(bwinton)
Attachment #583887 - Flags: review+
It looks the patch is only for (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #4)
> Comment on attachment 583887 [details] [diff] [review]
> XP polish
> 
> I mostly like it, and the code seems fine, so r=me, and ui-r=me, although I
> wonder how that'll look when the un-bolding-of-the-active-tab-title patch
> lands…

It looks the un-bolding-of-the-active-tab-title patch is only for Gnomestripe and Aero. Should I add it here?
Yeah, I think so.  I would also suggest removing it in Mac, but I don't think we do anything special to the active tab there…

Thanks,
Blake.
Attached patch XP polish v2Splinter Review
Because I've added the removing of the bolding of the active tab I'm asking again for review.
Attachment #583887 - Attachment is obsolete: true
Attachment #584074 - Flags: ui-review?(bwinton)
Attachment #584074 - Flags: review?(bwinton)
Comment on attachment 584074 [details] [diff] [review]
XP polish v2

Yeah, that looks more consistent with our other platforms.  ui-r=me.

>+++ b/mail/themes/qute/mail/messageWindow.css
>@@ -51,6 +51,10 @@
>+#mail-toolbox {

So, here we're adding "#mail-toolbox"

>+++ b/mail/themes/qute/mail/primaryToolbar.css
>@@ -63,14 +63,15 @@
>-#mail-toolbox {
>+.mail-toolbox {

But here we're changing "#mail-toolbox" to ".mail-toolbox"…

Other than that I like it, so if you can fix (or explain) that inconsistency, r=me, too.  :)

Thanks,
Blake.
Attachment #584074 - Flags: ui-review?(bwinton)
Attachment #584074 - Flags: ui-review+
Attachment #584074 - Flags: review?(bwinton)
Attachment #584074 - Flags: review+
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #9)
> Comment on attachment 584074 [details] [diff] [review]
> XP polish v2
> 
> Yeah, that looks more consistent with our other platforms.  ui-r=me.
> 
> >+++ b/mail/themes/qute/mail/messageWindow.css
> >@@ -51,6 +51,10 @@
> >+#mail-toolbox {
> 
> So, here we're adding "#mail-toolbox"
> 
> >+++ b/mail/themes/qute/mail/primaryToolbar.css
> >@@ -63,14 +63,15 @@
> >-#mail-toolbox {
> >+.mail-toolbox {
> 
> But here we're changing "#mail-toolbox" to ".mail-toolbox"…

The change to class is for Lightning and other Add-ons which want use this toolbox in their tabs.

In standalone window (messageWindow.css) I've used the ID to be the most powerful rule and I haven't to use !important. And here we don't need to be compatible with Lightning.
Keywords: checkin-needed
Attachment #584074 - Flags: approval-comm-aurora?
Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/dcd9503ca698
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #584074 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.