The default bug view has changed. See this FAQ.

Polish tabs-on-top theme on Windows XP

RESOLVED FIXED in Thunderbird 12.0

Status

Thunderbird
Toolbars and Tabs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

12 Branch
Thunderbird 12.0
All
Windows XP

Thunderbird Tracking Flags

(thunderbird11 fixed)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Some little changes to make TB look better under Windows XP after landing of Bug 644169
(Assignee)

Updated

5 years ago
Blocks: 644169
(Assignee)

Comment 1

5 years ago
Created attachment 583887 [details] [diff] [review]
XP polish

This patch fixes following:
Change the mail-toolbox definition from ID to class to apply also on the Lightning toolboxes (Bug 709572).

Let the text-shadow on active tabs with Personas (like Bug 710838).

Remove the double border in standalone window and remove the gradient.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #583887 - Flags: ui-review?(bwinton)
Attachment #583887 - Flags: review?(bwinton)
(Assignee)

Comment 2

5 years ago
Created attachment 583898 [details]
Standalone window comparison with before and after the patch
(Assignee)

Comment 3

5 years ago
Created attachment 583899 [details]
Personas tab comparison. Top is before the patch
Comment on attachment 583887 [details] [diff] [review]
XP polish

I mostly like it, and the code seems fine, so r=me, and ui-r=me, although I wonder how that'll look when the un-bolding-of-the-active-tab-title patch lands…
Attachment #583887 - Flags: ui-review?(bwinton)
Attachment #583887 - Flags: ui-review+
Attachment #583887 - Flags: review?(bwinton)
Attachment #583887 - Flags: review+
(Assignee)

Comment 5

5 years ago
It looks the patch is only for (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #4)
> Comment on attachment 583887 [details] [diff] [review]
> XP polish
> 
> I mostly like it, and the code seems fine, so r=me, and ui-r=me, although I
> wonder how that'll look when the un-bolding-of-the-active-tab-title patch
> lands…

It looks the un-bolding-of-the-active-tab-title patch is only for Gnomestripe and Aero. Should I add it here?
Yeah, I think so.  I would also suggest removing it in Mac, but I don't think we do anything special to the active tab there…

Thanks,
Blake.
(Assignee)

Comment 7

5 years ago
Created attachment 584074 [details] [diff] [review]
XP polish v2

Because I've added the removing of the bolding of the active tab I'm asking again for review.
Attachment #583887 - Attachment is obsolete: true
Attachment #584074 - Flags: ui-review?(bwinton)
Attachment #584074 - Flags: review?(bwinton)
(Assignee)

Comment 8

5 years ago
Created attachment 584086 [details]
Comparison between bold and normal active tab
Comment on attachment 584074 [details] [diff] [review]
XP polish v2

Yeah, that looks more consistent with our other platforms.  ui-r=me.

>+++ b/mail/themes/qute/mail/messageWindow.css
>@@ -51,6 +51,10 @@
>+#mail-toolbox {

So, here we're adding "#mail-toolbox"

>+++ b/mail/themes/qute/mail/primaryToolbar.css
>@@ -63,14 +63,15 @@
>-#mail-toolbox {
>+.mail-toolbox {

But here we're changing "#mail-toolbox" to ".mail-toolbox"…

Other than that I like it, so if you can fix (or explain) that inconsistency, r=me, too.  :)

Thanks,
Blake.
Attachment #584074 - Flags: ui-review?(bwinton)
Attachment #584074 - Flags: ui-review+
Attachment #584074 - Flags: review?(bwinton)
Attachment #584074 - Flags: review+
(Assignee)

Comment 10

5 years ago
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #9)
> Comment on attachment 584074 [details] [diff] [review]
> XP polish v2
> 
> Yeah, that looks more consistent with our other platforms.  ui-r=me.
> 
> >+++ b/mail/themes/qute/mail/messageWindow.css
> >@@ -51,6 +51,10 @@
> >+#mail-toolbox {
> 
> So, here we're adding "#mail-toolbox"
> 
> >+++ b/mail/themes/qute/mail/primaryToolbar.css
> >@@ -63,14 +63,15 @@
> >-#mail-toolbox {
> >+.mail-toolbox {
> 
> But here we're changing "#mail-toolbox" to ".mail-toolbox"…

The change to class is for Lightning and other Add-ons which want use this toolbox in their tabs.

In standalone window (messageWindow.css) I've used the ID to be the most powerful rule and I haven't to use !important. And here we don't need to be compatible with Lightning.
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Attachment #584074 - Flags: approval-comm-aurora?
Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/dcd9503ca698
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
tracking-thunderbird11: --- → ?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #584074 - Flags: approval-comm-aurora? → approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/e432f4f1d797
status-thunderbird11: --- → fixed
tracking-thunderbird11: ? → ---
You need to log in before you can comment on or make changes to this bug.