Closed Bug 713134 Opened 9 years ago Closed 8 years ago

Make packager.pm missing file warnings fatal on SeaMonkey

Categories

(SeaMonkey :: Build Config, enhancement, P1)

enhancement

Tracking

(seamonkey2.9 wontfix, seamonkey2.10 verified)

VERIFIED FIXED
seamonkey2.11
Tracking Status
seamonkey2.9 --- wontfix
seamonkey2.10 --- verified

People

(Reporter: rain1, Assigned: sgautherie)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

To do this, we need to clean up suite/installer/package-manifest.in, then set MOZ_PKG_FATAL_WARNINGS = 1 before including packager.mk in suite/installer/Makefile.in.
Depends on: 634439
Depends on: 564657
Depends on: 657208
Depends on: 595759
Depends on: 586854
Depends on: 586822
Depends on: 585462
Depends on: 565774
Depends on: 564606
Depends on: 660727
Depends on: 585460
Depends on: 534664
Depends on: 694371
Depends on: 564656
Depends on: 714252
Depends on: 714253
Version: SeaMonkey 2.7 Branch → Trunk
Depends on: 694353
Let's prepare for when blockers are fixed.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #586715 - Flags: review?(bugspam.Callek)
Severity: normal → enhancement
Flags: in-testsuite-
Whiteboard: [landing depends on fixing all blockers first]
Target Milestone: --- → Future
Depends on: 716395
Depends on: 717493
Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

Ian, maybe you can review this?
Attachment #586715 - Flags: review?(iann_bugzilla)
Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

Sorry this is more KaiRo's territory than mine
Attachment #586715 - Flags: review?(iann_bugzilla) → review?(kairo)
Priority: -- → P1
Depends on: 673867
Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

Review of attachment 586715 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, however I won't mark it r+ until after this _CAN_ land. So r- for now, re-request when you feel we're safe to land it.
Attachment #586715 - Flags: review?(kairo)
Attachment #586715 - Flags: review?(bugspam.Callek)
Attachment #586715 - Flags: review-
Attachment #586715 - Flags: feedback+
Depends on: 718912
Depends on: 721533
Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=e4cb299645a0
succeeds (so far), fwiw.
Attachment #586715 - Flags: review- → review?(bugspam.Callek)
Whiteboard: [landing depends on fixing all blockers first]
Target Milestone: Future → seamonkey2.10
Attachment #586715 - Flags: review?(iann_bugzilla)
Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

Probably more KaiRo's territory
Attachment #586715 - Flags: review?(iann_bugzilla) → review?(kairo)
Ping for review.
(In reply to Serge Gautherie (:sgautherie) from comment #7)
> Ping for review.

At least in my case, this is a waste of time, I'm marking such things TODO in my mailbox, but I can only work on things like this in my free time, which is pretty sparse since I started working full-time for something other than SeaMonkey. I will get to it, no worries. Also, people are reminded weekly by Bugzilla nowadays about their outstanding review requests anyhow, no need to send bugmail in addition.
As you know I have no say in this, but personally I feel if all dependencies have been resolved and everything looks OK (cf. comment 5), we should just flip the switch after the next uplift and see how it works. Since it's just a one line change, it's easy to back it out if it hurts.
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #9)

Makes sense (at this point): then my proposal would be to land asap on 2.10/central then wait for 2.9 to go to beta.

Pros: this has stalled for so long (as in already missed previous cycle), spare an approval+landing on aurora, have it active for next central cycle when it is likely to be most useful (I don't want to go chasing these warnings again!)...
Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

I won't mark this as reviewed, as Callek needs to deal with the fallout. I think this would be better to land on Wednesday, i.e. very early in 2.11a1, we're too late in the game for 2.10 and too busy with release stuff to reasonably do this right now, IMHO - but I'll leave that to Callek.
Attachment #586715 - Flags: review?(kairo)
Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

r+ but I want to ensure we're not chasing our own tail when this lands, so please land on wednesday. If all looks fine by friday I'll approve for aurora and we can chase down issues with it there.
Attachment #586715 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

http://hg.mozilla.org/comm-central/rev/d1ed30542ed0
Attachment #586715 - Attachment description: (Av1) Make packager.pm missing file warnings fatal on SeaMonkey. → (Av1) Make packager.pm missing file warnings fatal on SeaMonkey [Checked in: Comment 13]
Attachment #586715 - Flags: approval-comm-beta?
Attachment #586715 - Flags: approval-comm-aurora?
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: seamonkey2.10 → seamonkey2.11
Depends on: 735567
V.Fixed: catched bug 735567 right away ;->
Status: RESOLVED → VERIFIED
(In reply to Serge Gautherie (:sgautherie) from comment #14)
> V.Fixed: catched bug 735567 right away ;->

Serge, allow me to say (on the record) that if you (or anyone else with ability to review *any* code in SeaMonkey) notice packaging errors that turn us red, feel free to land the fix to package-manifest.in with rs+=me

My only requests are that a bug be on file for the change, and if there is a removed-files.in change is necessary it be attached to said bug (separately).

I don't require but would love at least a f? for the package-manifest.in change for a post-landing peek.

-- Good that in this case (catching the bustage) you landed a fix anyway.
Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

Marking aurora approval while I'm here :-) (I'll decide on beta a bit later)
Attachment #586715 - Flags: approval-comm-aurora? → approval-comm-aurora+
Depends on: 735618
(In reply to Justin Wood (:Callek) from comment #15)
> [...] rs+=me [and] at least a f? [...]

Right, that's exactly the expected process ;-)


(In reply to Justin Wood (:Callek) from comment #16)
> Marking aurora approval while I'm here :-) (I'll decide on beta a bit later)

Thanks, I concur to complete this step by step, letting the dust settle.
Depends on: 736864
> Depends on: 736864

http://hg.mozilla.org/mozilla-central/rev/da5e8f6a44bd
Back out a0fa92215a36 (bug 713132) for breaking --disable-updater as used in RPM nightlies
(In reply to Philip Chee from comment #18)

I'm not sure what your point was:

> > Depends on: 736864

--disable-updater is not used by SeaMonkey boxes, afaik.

> http://hg.mozilla.org/mozilla-central/rev/da5e8f6a44bd
> Back out a0fa92215a36 (bug 713132) for breaking --disable-updater as used in
> RPM nightlies

FF part has been fixed, and bug 713132 relanded.
Depends on: 738883
Depends on: 744026
Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

Let have this ride in from aurora... I don't think its worth the trouble on beta.
Attachment #586715 - Flags: approval-comm-beta? → approval-comm-beta-
Attachment #586715 - Attachment description: (Av1) Make packager.pm missing file warnings fatal on SeaMonkey [Checked in: Comment 13] → (Av1) Make packager.pm missing file warnings fatal on SeaMonkey [Checked in: Comment 13 & 21]
Depends on: 745998
Depends on: 748610
Depends on: 749114
Blocks: 763408
No longer blocks: 763408
Depends on: 763181
You need to log in before you can comment on or make changes to this bug.