713134 - Make packager.pm missing file warnings fatal on SeaMonkey

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, enhancement, P1)

Description

[Rain [:rain1] (inactive)]

To do this, we need to clean up suite/installer/package-manifest.in, then set MOZ_PKG_FATAL_WARNINGS = 1 before including packager.mk in suite/installer/Makefile.in.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Make packager.pm missing file warnings fatal on SeaMonkey [Checked in: Comment 13 & 21]

Let's prepare for when blockers are fixed.

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

Ian, maybe you can review this?

Comment 3

[Ian Neal]

Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

Sorry this is more KaiRo's territory than mine

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

Review of attachment 586715 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, however I won't mark it r+ until after this _CAN_ land. So r- for now, re-request when you feel we're safe to land it.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=e4cb299645a0
succeeds (so far), fwiw.

Comment 6

[Ian Neal]

Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

Probably more KaiRo's territory

Comment 7

[Serge Gautherie (:sgautherie)]

Ping for review.

Comment 8

[Robert Kaiser]

(In reply to Serge Gautherie (:sgautherie) from comment #7)
> Ping for review.

At least in my case, this is a waste of time, I'm marking such things TODO in my mailbox, but I can only work on things like this in my free time, which is pretty sparse since I started working full-time for something other than SeaMonkey. I will get to it, no worries. Also, people are reminded weekly by Bugzilla nowadays about their outstanding review requests anyhow, no need to send bugmail in addition.

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

As you know I have no say in this, but personally I feel if all dependencies have been resolved and everything looks OK (cf. comment 5), we should just flip the switch after the next uplift and see how it works. Since it's just a one line change, it's easy to back it out if it hurts.

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #9)

Makes sense (at this point): then my proposal would be to land asap on 2.10/central then wait for 2.9 to go to beta.

Pros: this has stalled for so long (as in already missed previous cycle), spare an approval+landing on aurora, have it active for next central cycle when it is likely to be most useful (I don't want to go chasing these warnings again!)...

Comment 11

[Robert Kaiser]

Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

I won't mark this as reviewed, as Callek needs to deal with the fallout. I think this would be better to land on Wednesday, i.e. very early in 2.11a1, we're too late in the game for 2.10 and too busy with release stuff to reasonably do this right now, IMHO - but I'll leave that to Callek.

Comment 12

[Justin Wood (:Callek)]

Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

r+ but I want to ensure we're not chasing our own tail when this lands, so please land on wednesday. If all looks fine by friday I'll approve for aurora and we can chase down issues with it there.

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

http://hg.mozilla.org/comm-central/rev/d1ed30542ed0

Comment 14

[Serge Gautherie (:sgautherie)]

V.Fixed: catched bug 735567 right away ;->

Comment 15

[Justin Wood (:Callek)]

(In reply to Serge Gautherie (:sgautherie) from comment #14)
> V.Fixed: catched bug 735567 right away ;->

Serge, allow me to say (on the record) that if you (or anyone else with ability to review *any* code in SeaMonkey) notice packaging errors that turn us red, feel free to land the fix to package-manifest.in with rs+=me

My only requests are that a bug be on file for the change, and if there is a removed-files.in change is necessary it be attached to said bug (separately).

I don't require but would love at least a f? for the package-manifest.in change for a post-landing peek.

-- Good that in this case (catching the bustage) you landed a fix anyway.

Comment 16

[Justin Wood (:Callek)]

Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

Marking aurora approval while I'm here :-) (I'll decide on beta a bit later)

Comment 17

[Serge Gautherie (:sgautherie)]

(In reply to Justin Wood (:Callek) from comment #15)
> [...] rs+=me [and] at least a f? [...]

Right, that's exactly the expected process ;-)


(In reply to Justin Wood (:Callek) from comment #16)
> Marking aurora approval while I'm here :-) (I'll decide on beta a bit later)

Thanks, I concur to complete this step by step, letting the dust settle.

Comment 18

[Philip Chee]

> Depends on: 736864

http://hg.mozilla.org/mozilla-central/rev/da5e8f6a44bd
Back out a0fa92215a36 (bug 713132) for breaking --disable-updater as used in RPM nightlies

Comment 19

[Serge Gautherie (:sgautherie)]

(In reply to Philip Chee from comment #18)

I'm not sure what your point was:

> > Depends on: 736864

--disable-updater is not used by SeaMonkey boxes, afaik.

> http://hg.mozilla.org/mozilla-central/rev/da5e8f6a44bd
> Back out a0fa92215a36 (bug 713132) for breaking --disable-updater as used in
> RPM nightlies

FF part has been fixed, and bug 713132 relanded.

Comment 20

[Justin Wood (:Callek)]

Comment on attachment 586715 [details] [diff] [review]
(Av1) Make packager.pm missing file warnings fatal on SeaMonkey
[Checked in: Comment 13 & 21]

Let have this ride in from aurora... I don't think its worth the trouble on beta.

Comment 21

[Justin Wood (:Callek)]

http://hg.mozilla.org/releases/comm-aurora/rev/6e46db9f7b18

Comment 22

[Serge Gautherie (:sgautherie)]

http://build.mozillamessaging.com/tinderboxpushlog/?tree=SeaMonkey-Aurora&rev=73a1f3d5bda7

seamonkey2.10: verified.