713154 - Various small perf improvements

Status: RESOLVED WONTFIX

(bugzilla.mozilla.org :: General, defect)

Description

[Frédéric Buclin]

Attachment: patch, v1

I found some places which could get some optimizations. I didn't do heavy testing, but it seems the win is of a few tenths of second. Still good to take. If you don't want this, feel free to mark the bug as wontfix.

To summarize what I did:

- In Bugzilla->active_custom_fields, use dclone() to copy active custom fields instead of running the query again everytime the criteria changes.

- Fix the logic in hook/bug/edit-after_custom_fields.html.tmpl to not loop over the list of custom fields twice. I also passed arguments to Bugzilla->active_custom_fields to move cf_hidden_in_product() out of the template. And show_custom_flags is useless.

- Fix bug/create/create.html.tmpl to pass enter_bug=>1 to Bugzilla->active_custom_fields to avoid getting a too large list.

Tell me what the perf win is for you, if any. I'm curious. :)

Comment 1

[David Lawrence [:dkl]]

Thanks Frederic. In my testing, I was unable to see much of any difference in timings when using the changes on my test system. But the changes do make sense logically in that we could see some future benefit from filtering the fields based on enter_bug for enter_bug.cgi as well as reducing duplicate looping in the templates where possible. I will
look at integrating these changes and pushing them live for some real world testing.

dkl

Comment 2

[Frédéric Buclin]

All the relevant changes have been made in bug 731850, which has a clear perf win. Marking this one as wontfix as no perf win was detected.