Closed Bug 713217 Opened 14 years ago Closed 14 years ago

Language Packs generate way too many useless validation errors

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Validation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Ken, Assigned: basta)

Details

(Whiteboard: [ReviewTeam])

The validator is throwing so many errors for language packs that it is exceedingly difficult to find legitimate errors that need to be addressed. For instance a common error that gets thrown is: ----- Unsafe remote resource found in language pack. Warning: Language packs are not allowed to contain references to remote resources. ----- This error gets thrown for links within translated strings and language packs have lots of links because Mozilla apps tend to have lots of links in their strings (e.g. About Firefox). Thus this validator rule throws lots of errors every time. Another common error is: ---- Required file missing Warning: This add-on is missing required files. Consult the documentation for a full list of required files. Warning: Add-ons of type 'language pack' require files: chrome/*.jar ---- The thing is my understanding is we are trying to encourage developers to not use internal JAR files anymore. In general, the validator needs to be much more selective about errors/warnings thrown for language packs otherwise they just get ignored and serious issues could get overlooked.
I suspect the 'remote resource' false positives are probably unavoidable. Not sure why the other one is so prevalent though.
OS: Windows XP → All
Hardware: x86 → All
Whiteboard: [required amo-editors]
Jorge, anything we can do here?
Assignee: nobody → jorge
Flagging links is necessary, since they have been used as a way to deliver malware before. As for the chrome/*.jar warning, I think that is not a real requirement. It seems like language packs work just fine without the internal JAR, so that warning can be removed. Are these bugs still being assigned to Matt?
Yep. So, the only thing to do here is remove the chrome/*.jar warning?
Yes, that's all that's needed.
Assignee: jorge → mattbasta
https://addons.mozilla.org/en-US/developers/addon/romanian-rom%C3%A2n%C4%83-language-pack/file/140282/validation is the validation check of a Romanian language pack where only the install.rdf has been altered compared to releases.mozilla.org version for Firefox 9.0.1. It would be nice if you can also check the other validator messages.
Done https://github.com/mozilla/amo-validator/pull/100 As far as the report in comment #6 goes, I'm not an admin on prod, so I'll need someone to pastebin that if you want me to look into whether any warnings are displayed in error.
CCing l10n lead for more information. The page linked in #c6 shows the following messages and warnings: Required file missing Warning: This add-on is missing required files. Consult the documentation for a full list of required files. Warning: Add-ons of type 'language pack' require files: chrome/*.jar Linked manifest could not be found. Warning: A linked manifest file could not be found in the package. Warning: Path: chrome/ro.manifest chrome.manifest 3 4 5 locale global-platform ro chrome/ro/locale/ro/global-platform/ manifest chrome/ro.manifest override chrome://mozapps/locale/downloads/settingsChange.dtd chrome://browser/locale/downloads/settingsChange.dtd Invalid chrome.manifest subject Warning: chrome.manifest files in language packs are only allowed to contain items that are prefixed with 'locale' or 'override'. Other values are not allowed. Warning: Invalid subject: manifest chrome.manifest 3 4 5 locale global-platform ro chrome/ro/locale/ro/global-platform/ manifest chrome/ro.manifest override chrome://mozapps/locale/downloads/settingsChange.dtd chrome://browser/locale/downloads/settingsChange.dtd Unsafe remote resource found in language pack. Warning: Language packs are not allowed to contain references to remote resources. chrome/ro/locale/browser/netError.dtd 97 98 ... ure informații private, folosind calculatorul dumneavoastră pentru a ataca altele sau provocând pagube calculatorului dumneavoastră.</p> <p>Proprietarii saiturilor web care cred că saitul lor a fost raportat ca unul de atac dintr-o greșeală pot <a href='http://www.stopbadwa ... Unsafe remote resource found in language pack. Warning: Language packs are not allowed to contain references to remote resources. chrome/ro/locale/ro/global/netError.dtd 84 85 ... ure informații private, folosind calculatorul dumneavoastră pentru a ataca altele sau provocând pagube calculatorului dumneavoastră.</p> <p>Proprietarii saiturilor web care cred că saitul lor a fost raportat ca unul de atac dintr-o greșeală pot <a href='http://www.stopbadwa ... tons of messages like these: Missing translation entity Warning: Localizations must include a translated copy of each entity from each file in the reference locale. The required files may vary from target application to target application. Warning: Missing Entities: GopherPromptTitle, GopherPromptText chrome/ro/locale/ro/necko//chrome/ro/locale/ro/necko/necko.properties Missing translation entity Warning: Localizations must include a translated copy of each entity from each file in the reference locale. The required files may vary from target application to target application. Warning: Missing Entities: netOffline.longDesc chrome/ro/locale/ro/global//chrome/ro/locale/ro/global/netError.dtd Missing translation entity Warning: Localizations must include a translated copy of each entity from each file in the reference locale. The required files may vary from target application to target application. Warning: Missing Entities: securityOverride.warningText chrome/ro/locale/ro/global//chrome/ro/locale/ro/global/netErrorApp.dtd Missing translation entity Warning: Localizations must include a translated copy of each entity from each file in the reference locale. The required files may vary from target application to target application. Warning: Missing Entities: x-gbk.title, utf-32.title, utf-32le.title, utf-32be.title chrome/ro/locale/ro/global//chrome/ro/locale/ro/global/charsetTitles.properties
Can you link me to the XPI or attach it?
The manifest chrome/ro.manifest line sounds like a bug in the packaging logic, can you file a firefox build config bug on that and CC me? No idea about the strings, it'd matter what we compare against here.
Pike: This has to do with problems in the AMO validator, not Firefox itself.
(In reply to Matt Basta from comment #11) > Pike: This has to do with problems in the AMO validator, not Firefox itself. For the most part yes, but the warning I commented on is actually a bug in the language packs as we generate them as part of the official bugs.
I'd like to make sure that the validator isn't generating that (those) warning(s) incorrectly before you guys spend time chasing down problems that don't exist. That's why I'm looking for the XPI to inspect manually.
(In reply to Matt Basta from comment #13) > I'd like to make sure that the validator isn't generating that (those) > warning(s) incorrectly before you guys spend time chasing down problems that > don't exist. That's why I'm looking for the XPI to inspect manually. https://addons.mozilla.org/firefox/downloads/file/140282/romanian_romana_language_pack-9.0-fx.xpi
> https://addons.mozilla.org/firefox/downloads/file/140282/ > romanian_romana_language_pack-9.0-fx.xpi Thanks. It looks like the error about chrome/ro.manifest is legitimate, but the error regarding "manifest" as an invalid prefix in chrome.manifest is not. We only recently started recognizing sub-manifests, and the language pack tests weren't accounted for. I've pushed a fix to the pull request for this bug, so it should land at the same time.
Merged: https://github.com/mozilla/amo-validator/commit/a48745800903e3f1bdba099eb9ca5ee71cb90d56
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.