713243 - Send quit-application in head_download_manager.js

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Send quit-application in head_download_manager.js

Attached patch is to be used on top of the patch for 713242.

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Combined patch pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=cbe3cfc61730

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 584073 [details] [diff] [review]
Send quit-application in head_download_manager.js

Review of attachment 584073 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/downloads/test/unit/head_download_manager.js
@@ +190,5 @@
>  Services.prefs.setBoolPref("browser.download.manager.showAlertOnComplete", false);
> +
> +do_register_cleanup(function() {
> +  let obsSvc = Components.classes["@mozilla.org/observer-service;1"].
> +    getService(Components.interfaces.nsIObserverService);

Import Services.jsm at the top (where XPCOMUtils.jsm is imported) and just use Services.obs here.

@@ +192,5 @@
> +do_register_cleanup(function() {
> +  let obsSvc = Components.classes["@mozilla.org/observer-service;1"].
> +    getService(Components.interfaces.nsIObserverService);
> +  obsSvc.notifyObservers(null, "quit-application", null);
> +})

missing semicolon

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2d36b9fd44ca

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/2d36b9fd44ca