Closed
Bug 713243
Opened 12 years ago
Closed 12 years ago
Send quit-application in head_download_manager.js
Categories
(Toolkit :: Downloads API, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(1 file)
747 bytes,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Attached patch is to be used on top of the patch for 713242.
Assignee | ||
Comment 2•12 years ago
|
||
Combined patch pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=cbe3cfc61730
Comment 3•12 years ago
|
||
Comment on attachment 584073 [details] [diff] [review] Send quit-application in head_download_manager.js Review of attachment 584073 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/downloads/test/unit/head_download_manager.js @@ +190,5 @@ > Services.prefs.setBoolPref("browser.download.manager.showAlertOnComplete", false); > + > +do_register_cleanup(function() { > + let obsSvc = Components.classes["@mozilla.org/observer-service;1"]. > + getService(Components.interfaces.nsIObserverService); Import Services.jsm at the top (where XPCOMUtils.jsm is imported) and just use Services.obs here. @@ +192,5 @@ > +do_register_cleanup(function() { > + let obsSvc = Components.classes["@mozilla.org/observer-service;1"]. > + getService(Components.interfaces.nsIObserverService); > + obsSvc.notifyObservers(null, "quit-application", null); > +}) missing semicolon
Attachment #584073 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2d36b9fd44ca
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2d36b9fd44ca
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•