Send quit-application in head_download_manager.js

RESOLVED FIXED in mozilla12

Status

()

Toolkit
Downloads API
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla12
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 584073 [details] [diff] [review]
Send quit-application in head_download_manager.js

Attached patch is to be used on top of the patch for 713242.
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #584073 - Flags: review?(mak77)
Combined patch pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=cbe3cfc61730
Comment on attachment 584073 [details] [diff] [review]
Send quit-application in head_download_manager.js

Review of attachment 584073 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/downloads/test/unit/head_download_manager.js
@@ +190,5 @@
>  Services.prefs.setBoolPref("browser.download.manager.showAlertOnComplete", false);
> +
> +do_register_cleanup(function() {
> +  let obsSvc = Components.classes["@mozilla.org/observer-service;1"].
> +    getService(Components.interfaces.nsIObserverService);

Import Services.jsm at the top (where XPCOMUtils.jsm is imported) and just use Services.obs here.

@@ +192,5 @@
> +do_register_cleanup(function() {
> +  let obsSvc = Components.classes["@mozilla.org/observer-service;1"].
> +    getService(Components.interfaces.nsIObserverService);
> +  obsSvc.notifyObservers(null, "quit-application", null);
> +})

missing semicolon
Attachment #584073 - Flags: review?(mak77) → review+
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2d36b9fd44ca
https://hg.mozilla.org/mozilla-central/rev/2d36b9fd44ca
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.