71326 - nsMenuBarListener eats all alt-combinations when it shouldn't

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Kathleen :Brade]

nsMenuBarListener eats all alt-[key] keypress events but it shouldn't if it's not 
handling the event.

in nsMenuBarListener::KeyPress, we return NS_ERROR_BASE if the alt key is pressed 
but we should do this probably only if (active).

This problem prevents alt-backspace from working in Composer (it does work in 
editfields because the events are propagated differently).

Comment 1

[Mike Pinkerton (not reading bugmail)]

Attachment: [patch] don't eat event if we didn't find shortcut

Comment 2

[Mike Pinkerton (not reading bugmail)]

kathy, can you try the attached patch and let me know if it helps?

Comment 3

[Mike Pinkerton (not reading bugmail)]

r=saari. need to track down an sr 

(oh, and i've fixed the typo - s/non/not - in the comment).

Comment 4

[Kathleen :Brade]

r=brade (too)

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

sr=shaver.

Comment 6

[Mike Pinkerton (not reading bugmail)]

fixed