Closed
Bug 713284
Opened 12 years ago
Closed 12 years ago
finalize statement in test_migration_to_2.js
Categories
(Toolkit :: Downloads API, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(1 file)
1.06 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=4351f854d713
Comment 2•12 years ago
|
||
Comment on attachment 584103 [details] [diff] [review] finalize statement in test_migration_to_2.js Review of attachment 584103 [details] [diff] [review]: ----------------------------------------------------------------- I think you can push all the test_migration* changesets in a single push, to save some resource. ::: toolkit/components/downloads/test/schema_migration/test_migration_to_2.js @@ +74,5 @@ > do_check_eq(1180493839859230, stmt.getInt64(3)); > do_check_eq(1180493839859230, stmt.getInt64(4)); > do_check_eq(1, stmt.getInt32(5)); > stmt.reset(); > + stmt.finalize(); The reset() call is useless and can be removed since we finalize it.
Attachment #584103 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=bf56294c4c87
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bf56294c4c87
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•