Closed
Bug 713288
Opened 12 years ago
Closed 12 years ago
finalize statement in test_migration_to_4.js
Categories
(Toolkit :: Downloads API, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(1 file)
1.72 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=3bfb97bcec4b
Comment 2•12 years ago
|
||
Comment on attachment 584110 [details] [diff] [review] finalize statement in test_migration_to_4.js Review of attachment 584110 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/downloads/test/schema_migration/test_migration_to_4.js @@ +73,5 @@ > do_check_eq(1, stmt.getInt32(5)); > do_check_eq("http://www.mozilla.com/en-US/products/download.html?product=firefox-2.0.0.6&os=osx&lang=en-US",stmt.getUTF8String(6)); > do_check_true(stmt.getIsNull(7)); > stmt.reset(); > + stmt.finalize(); The reset() call is useless and can be removed since we finalize it.
Attachment #584110 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=e96c48e7e919
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e96c48e7e919
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•