713325 - [mod_perl] Variable "$format" will not stay shared at request.cgi line 330

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Reed Loden [:reed]]

<dumitru> # /etc/init.d/httpd start
<dumitru> Starting httpd: WARNING: HOME is not set, using root: /
<dumitru> Variable "$format" will not stay shared at /data/www/bugzilla.mozilla.org/request.cgi line 330.

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 584156 [details] [diff] [review]
patch - v1

I would rather not have duplicate code if we can avoid it. I would suggest passing it in to the sub instead such as queue($format) or fix the closures properly.

Gerv, this is related to a recent change you made related to the CSV output of request.cgi. Can you take a look at reeds patch as well?

Comment 3

[:glob ✱]

gerv has already updated his patch to address this issue.  see bug 413851 comment 14.

as it's only a warning, and only displayed when apache is restarted, we may as well wait until the upstream patch has approval there, and bring across the fix for this issue to bmo at that point.

Comment 4

[:glob ✱]

upstream appears to be stalled; i've taken just the fix for this warning from gerv's patch and committed it.

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified request.cgi
Committed revision 8055.