713376 - Comment popup appearance broken by bug 497995 landing

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: fix v.1

Apparently the border-image spec changed, and now we need to say that we want the comment popup to be filled, rather than wanting it to look like unreadable crap. Chrome is using unprefixed, I don't actually know whether or not there are versions of either Chrome or Safari that used an updated version of -webkit prefixed, but it's probably better to spew even more parsing errors than to leave something looking like crap.

Comment 1

[Arpad Borsos [:Swatinem]]

Comment on attachment 584205 [details] [diff] [review]
fix v.1

Review of attachment 584205 [details] [diff] [review]:
-----------------------------------------------------------------

::: css/style.css
@@ +731,5 @@
>    border: solid transparent;
>    border-width: 10px 18px 25px;
>  }
>  .popupForm:nth-child(1n) {
>    -moz-border-image: url(../images/hudborderimage.png) 10 18 25 repeat;

So we need to keep the old version around for backward compat reasons?

Otherwise looks fine.

Comment 2

[Phil Ringnalda (:philor)]

Right: every version of Firefox from today's nightly back through whenever we start working, Fx2 maybe, reads that line, and nightlies dated 2011-12-23 or earlier, Fx11, Fx10, etc., say "okay, I'll make an uncrappy comment form out of that." Today's nightly says "oh, you want a tiny border, and white-on-white text, okay."

Then everything but today's nightly reads the next line with "fill" and says "parsing error, declaration dropped" while today's nightly says "oh, you want to be able to read the comment form, okay, we'll do that instead."

Comment 3

[Arpad Borsos [:Swatinem]]

Oh the joy of using experimental vendor prefixes. I guess we will have to live with it until someday when we can just drop them altogether.

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/a9d51f2493da

Comment 5

[Bill Gianopoulos [:WG9s]]

Attachment: Workaround

While waiting for the fix to land on the production server, I developed this userContent.css hack.  Sharing it here in case it helps others.

Comment 6

[Bill Gianopoulos [:WG9s]]

(In reply to Bill Gianopoulos from comment #5)
> Created attachment 584254 [details]
> Workaround
> 
> While waiting for the fix to land on the production server, I developed this
> userContent.css hack.  Sharing it here in case it helps others.

Well, that does not work as well as I thought.  Makes the popup display more or less correctly, but prevents the drag and drop to add builds to the comment from working.