Closed Bug 713408 Opened 9 years ago Closed 9 years ago

Don't clutter log with history entries in Profile Migrator

Categories

(Firefox for Android :: General, defect, P1)

ARM
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 12
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: philikon, Assigned: gcp)

Details

Attachments

(2 files, 1 obsolete file)

Attached file logcat (obsolete) —
Reproducible every time. Logcat is attached (minus private data spew from the profile migrator)
Could be a dupe of bug 712718 but we might need more of your logcat to be sure.
Since you are on nightly and the fix is on nightly, you could manually re-install and see if the crash is fixed. I suggest manually re-installing since you might not be running long enough to get to check for updates.
(In reply to Mark Finkle (:mfinkle) from comment #1)
> Could be a dupe of bug 712718 but we might need more of your logcat to be
> sure.

In what way? All previous lines contained profile migrator output (bookmarks & history) that I'm not willing to share publicly. If it helps I can send you a private email with the full logcat, I still have the file.
(In reply to Philipp von Weitershausen [:philikon] from comment #3)
> (In reply to Mark Finkle (:mfinkle) from comment #1)
> > Could be a dupe of bug 712718 but we might need more of your logcat to be
> > sure.
> 
> In what way? All previous lines contained profile migrator output (bookmarks
> & history) that I'm not willing to share publicly. If it helps I can send
> you a private email with the full logcat, I still have the file.

Oh! I see what you mean now. I assume the java.lang.IllegalStateException is crashing the app.
Assignee: nobody → gpascutto
Priority: -- → P1
The actual crash is not in the log pasted. The errors in the log pasted are caused by an unanticipated exception higher up.
Here's the full logcat. I cleaned up all private data. Hope this helps.
Attachment #584231 - Attachment is obsolete: true
This is a duplicate of 712718, but I'd like to abuse it to remove that logging, as you're not the first one to complain about it.
Comment on attachment 584414 [details] [diff] [review]
Patch 1. Reduce logging for Profile Migrator

Seems sensible to me (you might want to reflect the morphing in the bug title...). Obsessive logging is rarely a good idea in production code anyway, as it creates lots of unnecessary I/O.
Attachment #584414 - Flags: review?(philipp) → feedback+
Summary: 2011-12-24 nightly crashes after start → Don't clutter log with history entries in Profile Migrator
Attachment #584414 - Flags: review?(mark.finkle)
Comment on attachment 584414 [details] [diff] [review]
Patch 1. Reduce logging for Profile Migrator

We want this patch on Aurora too, if the migration code has landed there. Just request approval.
Attachment #584414 - Flags: review?(mark.finkle) → review+
Attachment #584414 - Flags: approval-mozilla-aurora?
Comment on attachment 584414 [details] [diff] [review]
Patch 1. Reduce logging for Profile Migrator

[triage comment]
Approved for aurora. Mobile only, low risk
Attachment #584414 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/7da491d262a3
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
tracking-fennec: --- → 11+
You need to log in before you can comment on or make changes to this bug.