Don't clutter log with history entries in Profile Migrator

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: philikon, Assigned: gcp)

Tracking

unspecified
Firefox 12
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 584231 [details]
logcat

Reproducible every time. Logcat is attached (minus private data spew from the profile migrator)
Could be a dupe of bug 712718 but we might need more of your logcat to be sure.
Since you are on nightly and the fix is on nightly, you could manually re-install and see if the crash is fixed. I suggest manually re-installing since you might not be running long enough to get to check for updates.
(In reply to Mark Finkle (:mfinkle) from comment #1)
> Could be a dupe of bug 712718 but we might need more of your logcat to be
> sure.

In what way? All previous lines contained profile migrator output (bookmarks & history) that I'm not willing to share publicly. If it helps I can send you a private email with the full logcat, I still have the file.
(In reply to Philipp von Weitershausen [:philikon] from comment #3)
> (In reply to Mark Finkle (:mfinkle) from comment #1)
> > Could be a dupe of bug 712718 but we might need more of your logcat to be
> > sure.
> 
> In what way? All previous lines contained profile migrator output (bookmarks
> & history) that I'm not willing to share publicly. If it helps I can send
> you a private email with the full logcat, I still have the file.

Oh! I see what you mean now. I assume the java.lang.IllegalStateException is crashing the app.
Assignee: nobody → gpascutto
Priority: -- → P1
(Assignee)

Comment 5

5 years ago
The actual crash is not in the log pasted. The errors in the log pasted are caused by an unanticipated exception higher up.
Created attachment 584406 [details]
full logcat (cleaned up)

Here's the full logcat. I cleaned up all private data. Hope this helps.
Attachment #584231 - Attachment is obsolete: true
(Assignee)

Comment 7

5 years ago
This is a duplicate of 712718, but I'd like to abuse it to remove that logging, as you're not the first one to complain about it.
(Assignee)

Comment 8

5 years ago
Created attachment 584414 [details] [diff] [review]
Patch 1. Reduce logging for Profile Migrator
Attachment #584414 - Flags: review?(philipp)
Comment on attachment 584414 [details] [diff] [review]
Patch 1. Reduce logging for Profile Migrator

Seems sensible to me (you might want to reflect the morphing in the bug title...). Obsessive logging is rarely a good idea in production code anyway, as it creates lots of unnecessary I/O.
Attachment #584414 - Flags: review?(philipp) → feedback+
(Assignee)

Updated

5 years ago
Summary: 2011-12-24 nightly crashes after start → Don't clutter log with history entries in Profile Migrator
(Assignee)

Updated

5 years ago
Attachment #584414 - Flags: review?(mark.finkle)
Comment on attachment 584414 [details] [diff] [review]
Patch 1. Reduce logging for Profile Migrator

We want this patch on Aurora too, if the migration code has landed there. Just request approval.
Attachment #584414 - Flags: review?(mark.finkle) → review+
(Assignee)

Updated

5 years ago
Attachment #584414 - Flags: approval-mozilla-aurora?

Comment 11

5 years ago
Comment on attachment 584414 [details] [diff] [review]
Patch 1. Reduce logging for Profile Migrator

[triage comment]
Approved for aurora. Mobile only, low risk
Attachment #584414 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 12

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7da491d262a3
https://hg.mozilla.org/mozilla-central/rev/7da491d262a3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
tracking-fennec: --- → 11+
status-firefox11: --- → affected
(Assignee)

Comment 14

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/9f80f3664500

Updated

5 years ago
status-firefox11: affected → fixed
You need to log in before you can comment on or make changes to this bug.