713433 - window.crypto.getRandomValues does not throw specific enough exceptions

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #440046 +++

window.crypto.getRandomValues throws exceptions of type DOMException instead of more specific types like QuotaExceededError, because we don't implement the WebIDL exception model yet (bug 691017).

When this change is made, the existing tests for window.crypto.getRandomValues must be updated to check for the more specific errors instead of checking for DOMException.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Bug 1030963 removed this functionality entirely.

Comment 2

[Tom S [:evilpie]]

getRandomValues is part of the WebCrypto API: http://www.w3.org/TR/WebCryptoAPI/#RandomSource-method-getRandomValues.
I am not sure about the exception, I see one reference to it here at least http://mxr.mozilla.org/mozilla-central/source/dom/base/Crypto.cpp#88.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

(Please don't link to TR/* specs. They are for trash. 
https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#RandomSource-method-getRandomValues)

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

D'oh - not paying enough attention. Thanks.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

The code is correct now, we just need some test coverage. Once <https://github.com/w3c/web-platform-tests/pull/1526> gets pulled into m-c, we can probably close this.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 7

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

The web-platform-tests changes have long since merged.