I found two small errors in Linux theme after landing of Bug 644169. With Personas applied the menu bar has a half transparent background color. Never functional selector in toolbar definition.
Created attachment 584273 [details] [diff] [review] Fix the two errors I think the menubar background is a remnant there the bar was planned below the tabs. The mail-toolbox:not(-moz-lwtheme) is never working because of the missing colon before -moz-lwtheme. I removed this selector and not fixed it because I think it's planned to use the gradient with personas like in the other themes.
Created attachment 584274 [details] Screenshot showing the menubar issue This screenshot shows how the menubar looks with personas.
Comment on attachment 584273 [details] [diff] [review] Fix the two errors So, Mike Conley has been doing a bunch of work both in relation to tabs-on-top, and on Linux, and even better, he's not on vacation this week, so I strongly suggest you ask him for review and ui-review next. ;) And the only reason I'm giving this patch the r- and ui-r- is because you seem to have uploaded a PNG file, instead of a patch, so there's nothing for me to review. ;) Hopefully Mike will be more lenient. :) Thanks, Blake.
Created attachment 584577 [details] [diff] [review] Fix the two errors Now the right patch.
Paenglab: Hm - can I assume this also applies to EarlyBird as well? -Mike
Comment on attachment 584577 [details] [diff] [review] Fix the two errors Code looks good to me.
Yes EarlyBird has the same code. This comes from the Tabs on top code.
5 years ago
Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/c55d07ab4294
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/72ae945fade3