713480 - Compressed entries stored as files are padded with zero bytes to the length of uncompressed size

Status: RESOLVED WONTFIX

(Core :: Networking: Cache, defect)

Description

[Michal Novotny [:michal]]

This is caused by fallocating of separate files.

http://hg.mozilla.org/mozilla-central/annotate/798b00a6fe29/netwerk/cache/nsDiskCacheStreams.cpp#l739

Comment 1

[Michal Novotny [:michal]]

Attachment: fix

Maybe we should also bump a cache version to get rid of these oversized entries?

Comment 2

[Michal Novotny [:michal]]

Comment on attachment 584294 [details] [diff] [review]
fix

Jason seems to be busy, requesting Bjarne.

Comment 3

[Bjarne (:bjarne)]

Comment on attachment 584294 [details] [diff] [review]
fix

Review of attachment 584294 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, assuming it passes tryserver. Let's not worry about the cache-bump here - I believe that will happen in any case e.g. as the solution to bug #715198

Comment 4

[Michal Novotny [:michal]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a76df5ba3dc2

Comment 5

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/4f2f486f898f - apparently test_bug650995.js liked that padding, and permanently fails like https://tbpl.mozilla.org/php/getParsedLog.php?id=8446297&tree=Mozilla-Inbound without it.

Comment 6

[Patrick McManus [:mcmanus]]

another case of an almost landed patch.. michal, should this bug be finished up or wontfixed?

Comment 7

[Michal Novotny [:michal]]

The patch wasn't needed because cache compression was never turned on. It isn't implemented in the new cache at all and probably will never be, so WONTFIX.