gPromptService is not defined trying to add empty contact from sidebar

RESOLVED FIXED in seamonkey2.9

Status

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: neil, Assigned: philip.chee)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.9
Dependency tree / graph
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.7 fixed, seamonkey2.8 fixed, seamonkey2.9 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Steps to reproduce problem:
1. Compose a message
2. Open the Address Book sidebar
3. Select a contact without an email address
4. Try to add the contact to the message

Actual result: Nothing happens.

Expected result: The same alert as you get in the Select Addresses dialog.

When I copied the code from the Select Addresses dialog to the address book panel I forgot to copy the gPromptService variable...
(Assignee)

Comment 1

7 years ago
Should be able to use Services.prompt.alert() now with Bug 671554 (Switch suite/mailnews to use Services.prompt)
(Assignee)

Comment 2

7 years ago
Oops I filed Bug 713671 (addressingWidgetOverlay.js uses non-existent gPromptService). Patches attached to that bug.
(Reporter)

Comment 3

7 years ago
(In reply to Philip Chee from comment #2)
> Oops I filed Bug 713671 (addressingWidgetOverlay.js uses non-existent
> gPromptService). Patches attached to that bug.
But not really relevant here though...
(Assignee)

Comment 4

7 years ago
Created attachment 584537 [details] [diff] [review]
Patch v1.0 Use Services.prompt.alert()

Services is available from utilityOverlay.js.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #584537 - Flags: review?(neil)
(Reporter)

Updated

7 years ago
Attachment #584537 - Flags: review?(neil) → review+
(Assignee)

Comment 5

7 years ago
Pushed to comm-central (finally IT fixed my c-c perms!)
http://hg.mozilla.org/comm-central/rev/5a6fd97bbd45
Target Milestone: --- → seamonkey2.9
(Assignee)

Comment 6

7 years ago
Comment on attachment 584537 [details] [diff] [review]
Patch v1.0 Use Services.prompt.alert()

Sort of regression fix.
Attachment #584537 - Flags: approval-comm-beta?
Attachment #584537 - Flags: approval-comm-aurora?
Blocks: 664838
Flags: in-testsuite-
Keywords: helpwanted
Whiteboard: [good first bug]

Updated

7 years ago
Attachment #584537 - Flags: approval-comm-beta?
Attachment #584537 - Flags: approval-comm-beta+
Attachment #584537 - Flags: approval-comm-aurora?
Attachment #584537 - Flags: approval-comm-aurora+
(Assignee)

Comment 7

7 years ago
Pushed:
http://hg.mozilla.org/releases/comm-aurora/rev/04db92f7d627
http://hg.mozilla.org/releases/comm-beta/rev/6dc43d723766
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
status-seamonkey2.7: --- → fixed
status-seamonkey2.8: --- → fixed
status-seamonkey2.9: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.