This bug report will be used to attach the diffs for XUL-related files from the IBM bidi project.
Created attachment 27176 [details] [diff] [review] diffs for a XUL-related file from IBM bidi project
Dave, please (have someone) review these changes. Thanks!
IBM needs to patch the outliner code as well (which just recently landed). It draws and crops its own text.
set to moz 0.9
David, could we have an r or sr for the patch that is already in this bug report, or do you want to see the outliner changes first?
Do we need this to trun on IBMBID flag ? Can we land this later if hyatt do not have time to look at it soon?
erik resign. reassign all his bug to ftang for now.
hyatt- pleae review this as module owner.
It looks like the bidi engine leaks. nsIBidi is fetched without using a COM ptr.
simon- I think we should use nsCOMPtr inside nsBidiPresUtils for mBidiEngine and mUnicodeUtils. Also, we should AddRef for GetBidiEngine. I am working on a fix for this
here is a better patch 1. we make the nsBidiPresUtil using nsCOMPtr for service so we won't leak them 2. we use nsCOMPtr in the xul so we won't leak them. the nsBidiPresUtil itself is not an com object so we don't do that.
change stuats to wait for hyatt's review for new patch since 2001-05-10 15:54
fixed and check in
rs verify checkin.