XUL-related changes from IBM bidi project

VERIFIED FIXED in mozilla0.9.1

Status

()

Core
XUL
VERIFIED FIXED
17 years ago
9 years ago

People

(Reporter: Erik van der Poel, Assigned: Frank Tang)

Tracking

Trunk
mozilla0.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: r/sr=hyatt 2001-05-10 16:08 wait for check in)

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
This bug report will be used to attach the diffs for XUL-related files from the
IBM bidi project.
(Reporter)

Comment 1

17 years ago
Created attachment 27176 [details] [diff] [review]
diffs for a XUL-related file from IBM bidi project
(Reporter)

Comment 2

17 years ago
Dave, please (have someone) review these changes. Thanks!

Comment 3

17 years ago
IBM needs to patch the outliner code as well (which just recently landed).  It
draws and crops its own text.
(Assignee)

Comment 4

17 years ago
set to moz 0.9
Target Milestone: --- → mozilla0.9
(Reporter)

Comment 5

17 years ago
David, could we have an r or sr for the patch that is already in this bug
report, or do you want to see the outliner changes first?
(Assignee)

Comment 6

17 years ago
Do we need this to trun on IBMBID flag ? Can we land this later if hyatt do not 
have time to look at it soon?
(Reporter)

Updated

17 years ago
Target Milestone: mozilla0.9 → mozilla0.9.1
(Assignee)

Comment 7

17 years ago
erik resign. reassign all his bug to ftang for now.
Assignee: erik → ftang
(Assignee)

Comment 8

17 years ago
hyatt- pleae review this as module owner.
Status: NEW → ASSIGNED
Whiteboard: wait for hyatt's review since 2001-05-07 23:42

Comment 9

17 years ago
It looks like the bidi engine leaks.  nsIBidi is fetched without using a COM 
ptr.
(Assignee)

Comment 10

17 years ago
simon- 
I think we should use nsCOMPtr inside nsBidiPresUtils for mBidiEngine and 
mUnicodeUtils. Also, we should AddRef for GetBidiEngine. I am working on a fix 
for this
(Assignee)

Comment 11

17 years ago
here is a better patch
1. we make the nsBidiPresUtil using nsCOMPtr for service so we won't leak them
2. we use nsCOMPtr in the xul so we won't leak them. 
the nsBidiPresUtil itself is not an com object so we don't do that.
(Assignee)

Comment 12

17 years ago
Created attachment 33966 [details] [diff] [review]
new patch
(Assignee)

Comment 13

17 years ago
change stuats to
wait for hyatt's review for new patch since 2001-05-10 15:54
Whiteboard: wait for hyatt's review since 2001-05-07 23:42 → wait for hyatt's review for new patch since 2001-05-10 15:54

Comment 14

17 years ago
ok, sr=hyatt
(Assignee)

Updated

17 years ago
Whiteboard: wait for hyatt's review for new patch since 2001-05-10 15:54 → r/sr=hyatt 2001-05-10 16:08 wait for check in
(Assignee)

Comment 15

17 years ago
fixed and check in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Updated

16 years ago
Status: RESOLVED → VERIFIED

Comment 16

16 years ago
rs verify checkin.
Blocks: 80130

Updated

9 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.