71367 - use Node::getBaseURI to resolve relative urls for import and include

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Now that we have Node::getBaseURI in the tree we should use it when resolving 
relative URI's for xsl:import and xsl:include. My plan is to remove the current 
code that handels the base URIs and use Node::getBaseURI instead, is this ok 
with everyone?

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The attached patch changes the code for <xsl:include> to use getBaseURI as well 
as removes the old code for handeling base URIs

we don't seem to support <xsl:import> ???

Comment 3

[Peter Van der Beken [:peterv]]

r=peterv.

Comment 4

[Mike Shaver (:shaver emeritus)]

+      /* XXX this is wrong, it's allowed to include one stylesheet multiple
+         times but we should build some sort of stack to make sure that we
+         don't have circular inclusions */

If that's legal, then why not just skip the processing of a sheet on subsequent
inclusions?  That's wbat the xpidl compiler does: if we've seen an include
before, we just skip over it, because we've already seen the effects of it (or
will, if we're still processing it when we hit a potentially-circular include).

sr=shaver

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Two reasons:

1. According to the spec it's illegal to have circular inclusions

2. There are some override mechanisms that makes it wrong to just skip an
   inclusion if a stylesheet has already been included

Comment 6

[Peter Van der Beken [:peterv]]

Checked in.

Comment 7

[Axel Hecht]

bitching buttons, verfication spam