713671 - addressingWidgetOverlay.js uses non-existent gPromptService

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Philip Chee]

> +++ This bug was initially created as a clone of Bug #671554 +++

> We import Services.jsm but we need to make better use of prompt provided by
>  it.
> This patch:
> * Switches suite code to use prompt provided by Services.jsm
> * Done some minor code simplification.
IanN missed usage of gPromptService in addressingWidgetOverlay.js:
http://mxr.mozilla.org/comm-central/search?string=gpromptservice&find=%2Fsuite%2Fmailnews%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed Fix.

> -var test_addresses_sequence = false;
> -
> -try {
> -  if (sPrefs)
> -    test_addresses_sequence = sPrefs.getBoolPref("mail.debug.test_addresses_sequence");
> -}
> -catch (ex) {}
> +var test_addresses_sequence = getPref("mail.debug.test_addresses_sequence");

If getPrefType()returns nsIPrefBranch.PREF_INVALID, getPref() returns null.
And doesn't throw (I think).

> -    gPromptService.alert(window, generalErrString, specificErrString);
> +    Services.prompt.alert(window, generalErrString, specificErrString);

Can't test directly but from code inspection should work. Tested with ExecuteJS:

1. Install ExecuteJS.
2. From the context of the compose window execute:
Services.prompt.alert(window, "General Error", "Specific Error");

Comment 2

[Philip Chee]

Attachment: Patch Bv1.0 Minimal Branch Patch.

Requesting approval for comm-aurora and comm-beta because the dependent patch landed in those repositories.

Comment 3

[Ian Neal]

(In reply to Philip Chee from comment #0)
> > +++ This bug was initially created as a clone of Bug #671554 +++
> 
> > We import Services.jsm but we need to make better use of prompt provided by
> >  it.
> > This patch:
> > * Switches suite code to use prompt provided by Services.jsm
> > * Done some minor code simplification.
> IanN missed usage of gPromptService in addressingWidgetOverlay.js:
> http://mxr.mozilla.org/comm-central/
> search?string=gpromptservice&find=%2Fsuite%2Fmailnews%2F&findi=&filter=^[^\0]
> *%24&hitlimit=&tree=comm-central

That also gives another file as using gPromptService, addressbook-panel.js

Comment 4

[Philip Chee]

> That also gives another file as using gPromptService, addressbook-panel.js
Bug 713563 gPromptService is not defined trying to add empty contact from sidebar r=Neil.

Comment 5

[Ian Neal]

Comment on attachment 584451 [details] [diff] [review]
Patch v1.0 Proposed Fix.

I seem to remember a patch elsewhere for the sPrefs stuff in MsgComposeCommands.js

Comment 6

[Philip Chee]

> Attachment #584453 [details] [diff] - Flags: approval-comm-beta? → approval-comm-beta+
> Attachment #584453 [details] [diff] - Flags: approval-comm-aurora? → approval-comm-aurora+
Pushed:
http://hg.mozilla.org/releases/comm-aurora/rev/994869ef8fad
http://hg.mozilla.org/releases/comm-beta/rev/405c38f9cbec

Comment 7

[Philip Chee]

> I seem to remember a patch elsewhere for the sPrefs stuff in MsgComposeCommands.js
sPrefs stub remains until Neil gets around to rewriting the LDAP code.

Comment 8

[Philip Chee]

Pushed to comm-central!
http://hg.mozilla.org/comm-central/rev/9de6fd3a8f73