Note: There are a few cases of duplicates in user autocompletion which are being worked on.

check in several layout related changes from IBM bidi project

VERIFIED FIXED in mozilla0.8.1

Status

()

Core
Layout
P1
normal
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: Erik van der Poel, Assigned: Erik van der Poel)

Tracking

Trunk
mozilla0.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

17 years ago
This bug report will be used to attach a number of changes in the layout area
from the IBM bidi project.
(Assignee)

Comment 1

17 years ago
Created attachment 27196 [details] [diff] [review]
diffs for several layout related files from IBM bidi project
(Assignee)

Comment 2

17 years ago
Yesterday, Marc kindly came up to Mountain View to go over these changes, and
approved them for check-in. I've also gone over them.

r=attinasi
sr=erik
(Assignee)

Comment 3

17 years ago
Created attachment 27204 [details]
mozilla/layout/base/public/nsBidiPresUtils.h
(Assignee)

Comment 4

17 years ago
Created attachment 27205 [details]
mozilla/layout/base/src/nsBidiPresUtils.cpp
(Assignee)

Comment 5

17 years ago
nsBidiPresUtils.{cpp,h} have also been reviewed by attinasi and erik.
(Assignee)

Updated

17 years ago
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Priority: -- → P1
Resolution: --- → FIXED
Target Milestone: --- → mozilla0.8.1
(Assignee)

Comment 6

17 years ago
Changes and new files checked in.

Comment 7

16 years ago
Marking verified per last comments
Status: RESOLVED → VERIFIED

Comment 8

14 years ago
The patch in this bug contains a test that is commented as
  this must be a non-renderable frame creatd at the 
  end of the line by Bidi reordering

I suspect the assumption that an empty frame is caused by "BIDI reordering at
the end of a line" is incorrect in the general case.

Removing this text altogether seems to fix bug 202046.

I guess we should find a different test for identifying empty frames caused by
Bidi reordering at line ends? Or can this test and action get removed altogether?
You need to log in before you can comment on or make changes to this bug.