Last Comment Bug 713773 - Ensure GC Statistics totals are initialized
: Ensure GC Statistics totals are initialized
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Bill McCloskey (:billm)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-27 15:51 PST by Bill McCloskey (:billm)
Modified: 2011-12-28 11:10 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.18 KB, patch)
2011-12-27 15:51 PST, Bill McCloskey (:billm)
igor: review+
Details | Diff | Splinter Review

Description Bill McCloskey (:billm) 2011-12-27 15:51:45 PST
Created attachment 584501 [details] [diff] [review]
fix

Julian found this bug while running valgrind. The counts, totals, and startupTime fields are not getting initialized if MOZ_GCTIMER is unset. This didn't used to be a problem. But now we use the same facility for sending GC info to the error log. It uses the counts data, but not totals or startupTime. I just moved the initialization up.
Comment 2 Matt Brubeck (:mbrubeck) 2011-12-28 11:10:25 PST
https://hg.mozilla.org/mozilla-central/rev/35674d1a5efb

Note You need to log in before you can comment on or make changes to this bug.