Last Comment Bug 713828 - Stop styling page-proxy-stack
: Stop styling page-proxy-stack
Status: RESOLVED FIXED
[good first bug][mentor=dao][lang=css]
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 12
Assigned To: mr.Shu
:
Mentors:
Depends on:
Blocks: 702926
  Show dependency treegraph
 
Reported: 2011-12-28 02:21 PST by Dão Gottwald [:dao]
Modified: 2011-12-31 19:48 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Pemoved page-proxy-stack and page-proxy-favicon edited as requested (1.94 KB, patch)
2011-12-29 13:00 PST, mr.Shu
dao+bmo: review+
Details | Diff | Splinter Review

Description Dão Gottwald [:dao] 2011-12-28 02:21:19 PST
http://mxr.mozilla.org/mozilla-central/search?string=page-proxy-stack

page-proxy-stack is unnecessary, as it contains only one node (page-proxy-favicon). In pinstripe, page-proxy-stack can be removed right away. In winstripe and gnomestripe, it has padding which should be converted to margin on page-proxy-favicon.
Comment 1 mr.Shu 2011-12-29 13:00:36 PST
Created attachment 584822 [details] [diff] [review]
Pemoved page-proxy-stack and page-proxy-favicon edited as requested
Comment 2 Dão Gottwald [:dao] 2011-12-30 06:36:00 PST
Comment on attachment 584822 [details] [diff] [review]
Pemoved page-proxy-stack and page-proxy-favicon edited as requested

Thanks!

A flawless first patch -- something you don't see very often. :)
Comment 3 mr.Shu 2011-12-30 06:44:28 PST
It was a great example of good first bug although there was not much to fix.
Comment 5 Phil Ringnalda (:philor) 2011-12-31 19:48:38 PST
https://hg.mozilla.org/mozilla-central/rev/3e7c2110dec8

Note You need to log in before you can comment on or make changes to this bug.