Stop styling page-proxy-stack

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Theme
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dao, Assigned: mr.Shu)

Tracking

Trunk
Firefox 12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=dao][lang=css])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
http://mxr.mozilla.org/mozilla-central/search?string=page-proxy-stack

page-proxy-stack is unnecessary, as it contains only one node (page-proxy-favicon). In pinstripe, page-proxy-stack can be removed right away. In winstripe and gnomestripe, it has padding which should be converted to margin on page-proxy-favicon.
(Assignee)

Comment 1

6 years ago
Created attachment 584822 [details] [diff] [review]
Pemoved page-proxy-stack and page-proxy-favicon edited as requested
(Reporter)

Updated

6 years ago
Assignee: nobody → mrshux
Status: NEW → ASSIGNED
Summary: Remove page-proxy-stack → Stop styling page-proxy-stack
(Reporter)

Comment 2

6 years ago
Comment on attachment 584822 [details] [diff] [review]
Pemoved page-proxy-stack and page-proxy-favicon edited as requested

Thanks!

A flawless first patch -- something you don't see very often. :)
Attachment #584822 - Flags: review+
(Reporter)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

6 years ago
It was a great example of good first bug although there was not much to fix.
(Reporter)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/3e7c2110dec8
Keywords: checkin-needed
Target Milestone: --- → Firefox 12
https://hg.mozilla.org/mozilla-central/rev/3e7c2110dec8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.