Closed Bug 713828 Opened 8 years ago Closed 8 years ago

Stop styling page-proxy-stack

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 12

People

(Reporter: dao, Assigned: mrshux)

References

Details

(Whiteboard: [good first bug][mentor=dao][lang=css])

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/search?string=page-proxy-stack

page-proxy-stack is unnecessary, as it contains only one node (page-proxy-favicon). In pinstripe, page-proxy-stack can be removed right away. In winstripe and gnomestripe, it has padding which should be converted to margin on page-proxy-favicon.
Assignee: nobody → mrshux
Status: NEW → ASSIGNED
Summary: Remove page-proxy-stack → Stop styling page-proxy-stack
Comment on attachment 584822 [details] [diff] [review]
Pemoved page-proxy-stack and page-proxy-favicon edited as requested

Thanks!

A flawless first patch -- something you don't see very often. :)
Attachment #584822 - Flags: review+
Keywords: checkin-needed
It was a great example of good first bug although there was not much to fix.
https://hg.mozilla.org/mozilla-central/rev/3e7c2110dec8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.