IonMonkey: fix arrayPrototypeHasIndexedProperty

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 584572 [details] [diff] [review]
Patch

Move ArrayPrototypeHasIndexedProperty from JM to jsinfer and use it in Ion. The old copy in TypeOracle was incorrect (since ObjShrink landed I guess), so I'd like to have this in one place.

I can land the non-Ion part on inbound first.
Attachment #584572 - Flags: review?(bhackett1024)
Comment on attachment 584572 [details] [diff] [review]
Patch

Review of attachment 584572 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonBuilder.cpp
@@ +2786,5 @@
>  
>  bool
>  IonBuilder::jsop_getelem_dense()
>  {
> +    if (types::ArrayPrototypeHasIndexedProperty(cx, script))

Shouldn't this still depend on the oracle?  What if the TI oracle is not in use?

@@ +2848,5 @@
>  
>  bool
>  IonBuilder::jsop_setelem_dense()
>  {
> +    if (types::ArrayPrototypeHasIndexedProperty(cx, script))

Ditto.
Attachment #584572 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 3

6 years ago
(In reply to Brian Hackett (:bhackett) from comment #2)
> 
> Shouldn't this still depend on the oracle?  What if the TI oracle is not in
> use?

Hm agreed, I will move it back to the oracle. Thanks for the quick review!
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c377af7c014d

Please don't close this bug, I still have to land the IonMonkey part.
https://hg.mozilla.org/mozilla-central/rev/c377af7c014d
Target Milestone: --- → mozilla12
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/projects/ionmonkey/rev/97109df486a4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.