Closed
Bug 713909
Opened 13 years ago
Closed 11 years ago
[tinder] generateLog should raise better errors on missing files
Categories
(Webtools Graveyard :: Elmo, defect, P5)
Tracking
(Not tracked)
RESOLVED
FIXED
3.2
People
(Reporter: peterbe, Assigned: peterbe)
Details
Attachments
(1 file)
|
2.07 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
At the moment, the generateLog() function raises 404 errors when files are wrong or missing. https://github.com/mozilla/elmo/blob/develop/apps/tinder/views.py#L707 4xx errors should only be used when clients are using bad arguments and it means nothing is wrong with the server. However, the reason we get these errors is because it's configured wrong. We should raise a more descriptive error. Also, considering that generateLog() is not a view function it shouldn't raise web related errors. A regular IOError or ValueError should suffice as that would indicate to us what needs to be done to fix the problem.
|
Assignee | |
Updated•12 years ago
|
Priority: -- → P5
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → peterbe
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #733573 -
Flags: review?(l10n)
|
||
Updated•11 years ago
|
Attachment #733573 -
Flags: review?(l10n) → review+
|
||
Comment 2•11 years ago
|
||
Commit pushed to develop at https://github.com/mozilla/elmo https://github.com/mozilla/elmo/commit/34492dc40e1a48086bf8a7b405c1a904ab04847c fixes bug 713909 - [tinder] generateLog should raise better errors on missing files, r=Pike
|
|
||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Updated•11 years ago
|
Target Milestone: --- → 3.3
|
|
||
Updated•11 years ago
|
Target Milestone: 3.3 → 3.2
|
||
Updated•4 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•