[tinder] generateLog should raise better errors on missing files

RESOLVED FIXED in 3.2

Status

Webtools
Elmo
P5
normal
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
At the moment, the generateLog() function raises 404 errors when files are wrong or missing. 
https://github.com/mozilla/elmo/blob/develop/apps/tinder/views.py#L707

4xx errors should only be used when clients are using bad arguments and it means nothing is wrong with the server. However, the reason we get these errors is because it's configured wrong. 

We should raise a more descriptive error. Also, considering that generateLog() is not a view function it shouldn't raise web related errors. A regular IOError or ValueError should suffice as that would indicate to us what needs to be done to fix the problem.
(Assignee)

Updated

7 years ago
Priority: -- → P5
(Assignee)

Updated

7 years ago
Assignee: nobody → peterbe
(Assignee)

Comment 1

5 years ago
Created attachment 733573 [details] [diff] [review]
No more client errors if the settings.LOG_MOUNTS is configured wrong
Attachment #733573 - Flags: review?(l10n)
Attachment #733573 - Flags: review?(l10n) → review+

Comment 2

5 years ago
Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/34492dc40e1a48086bf8a7b405c1a904ab04847c
fixes bug 713909 - [tinder] generateLog should raise better errors on missing files, r=Pike

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.3
Target Milestone: 3.3 → 3.2
You need to log in before you can comment on or make changes to this bug.