Persona is no longer an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 713952 - IonMonkey: Crash in math-cordic with --ion -n
: IonMonkey: Crash in math-cordic with --ion -n
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: David Anderson [:dvander]
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: 677337
  Show dependency treegraph
Reported: 2011-12-28 14:09 PST by David Anderson [:dvander]
Modified: 2011-12-30 16:28 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (1.84 KB, patch)
2011-12-28 14:13 PST, David Anderson [:dvander]
sstangl: review+
Details | Diff | Splinter Review

Description David Anderson [:dvander] 2011-12-28 14:09:19 PST
This test currently segfaults with LSRA.
Comment 1 David Anderson [:dvander] 2011-12-28 14:13:04 PST
Created attachment 584642 [details] [diff] [review]

The bug is a regression from bug 695075. When we re-use a Value slot for a double, we have to compute its base since it could be off by 4 bytes.
Comment 2 Sean Stangl [:sstangl] 2011-12-30 15:12:25 PST
Comment on attachment 584642 [details] [diff] [review]

Review of attachment 584642 [details] [diff] [review]:

::: js/src/ion/C1Spewer.cpp
@@ +55,5 @@
>  bool
>  C1Spewer::init(const char *path)
>  {
> +    spewout_ = fopen(path, "a");

This seems dangerous. We should keep overwriting by default. I will not remember to periodically clear this file manually.
Comment 3 David Anderson [:dvander] 2011-12-30 16:28:12 PST (w/ fopen change reverted)

Note You need to log in before you can comment on or make changes to this bug.