function does not always return a value JS warnings in chrome://messenger/content/accountcreation/

RESOLVED FIXED in Thunderbird 12.0

Status

Thunderbird
Account Manager
--
trivial
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Thunderbird 12.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 584661 [details] [diff] [review]
Patch

I see these 2 JS strict warnings in my error console each time I start Thunderbird

Warning: anonymous function does not always return a value
Source File: chrome://messenger/content/accountcreation/emailWizard.js
Line: 695, Column: 4
Source Code:
    return this._foundConfig2(config); 

Warning: function verifyConfig does not always return a value
Source File: chrome://messenger/content/accountcreation/verifyConfig.js
Line: 66

I don't like noise in my error console, so I'm attaching a trivial patch to fix these 2 warnings.
Attachment #584661 - Flags: review?(bwinton)
Comment on attachment 584661 [details] [diff] [review]
Patch

Review of attachment 584661 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.  r=me if the tests still pass.  ;)
Attachment #584661 - Flags: review?(bwinton) → review+
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/619bee8cb53c
Assignee: nobody → florian
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
You need to log in before you can comment on or make changes to this bug.